Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[button-group] border is not rounded if the last button is wrapped in popover things #1967

Closed
wzhudev opened this issue Aug 10, 2018 · 1 comment
Closed

[button-group] border is not rounded if the last button is wrapped in popover things #1967

wzhudev opened this issue Aug 10, 2018 · 1 comment
Assignees
@hsuanxyz
Labels
🐛 Bug

Comments

@wzhudev
Copy link
Member

wzhudev commented Aug 10, 2018

Version

1.3.0

Environment

Anywhere

Reproduction link

https://stackblitz.com/edit/ng-zorro-antd-start-z8n3yw?file=src%2Fapp%2Fapp.component.html

Steps to reproduce

No

What is expected?

The last button should have a rounded corner.

What is actually happening?

The corner is rectangular.

Other?

The reason is the DOM structure. Popover component's DOM is the last sibling of the buttons', so CSS breaks.
@wzhudev wzhudev changed the title [button-group] border is not rounded if the last element is wrapped in popover things [button-group] border is not rounded if the last button is wrapped in popover things Aug 10, 2018
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 10, 2018
@hsuanxyz
fix(module:tooltip,popconfirm,popover): not create element when use d…
643cdcc 
…irective

close NG-ZORRO#1967
@hsuanxyz hsuanxyz mentioned this issue Aug 10, 2018
Merged
3 tasks
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 19, 2018
@hsuanxyz
fix(module:tooltip,popconfirm,popover): not create element when use d…
67bb46f 
…irective

close NG-ZORRO#1967
@lock
Copy link

lock bot commented Aug 19, 2019

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 19, 2019
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
@hsuanxyz
fix(module:tooltip,popconfirm,popover): not create element when use d…
743f571 
…irective (NG-ZORRO#1968)

close NG-ZORRO#1967
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hsuanxyz hsuanxyz

Labels
🐛 Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wzhudev @hsuanxyz