Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Metric model #597

Closed
laurenwalker opened this issue May 3, 2018 · 1 comment
Closed

Create Metric model #597

laurenwalker opened this issue May 3, 2018 · 1 comment
Labels
metrics Tickets for buiilding and maintaining metrics displays metrics-display
Milestone
2.1.0

Comments

@laurenwalker
Copy link
Member

The metric model is going to represent one single metric, such as investigations over all time or investigations in a single month.
@laurenwalker laurenwalker added metrics Tickets for buiilding and maintaining metrics displays metrics-display labels May 3, 2018
@mbjones mbjones added the next label May 3, 2018
rushirajnenuji referenced this issue May 16, 2018
@rushirajnenuji
Refactoring Metric Model
09c04ed 
Storing individual metrics and facets into its own array
rushirajnenuji added a commit that referenced this issue Jun 12, 2018
@rushirajnenuji
Creating metricsRequest object and quering the metrics service runnin…
86a59cc 
…g on log-proc server

Reference: #594 , #597 , #598
rushirajnenuji added a commit that referenced this issue Jun 18, 2018
@rushirajnenuji
Setting up constants into AppModel.js
d1abc0e 
Reference: #597
@rushirajnenuji
Copy link
Member

Initially created a single metric model for each type of metric. However, the problem with that was we were having n fetch() calls for n metrics. (so in our case 3 fetch() calls for 3 metrics, each fetching the same information!)

In the meeting we decided to rename it to metricsModel which would handle all n metrics (3 for the MVP) and would do only a single fetch call.

Solved with f1f0cb9

This was referenced Jun 19, 2018
Closed
Closed
Closed
Closed
Closed
@laurenwalker laurenwalker added this to the 2.1.0 milestone Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
metrics Tickets for buiilding and maintaining metrics displays metrics-display
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
3 participants
@mbjones @laurenwalker @rushirajnenuji