Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dtc/develop from NOAA-EMC develop 2020/07/21, prepare for SRW App #62

Merged
merged 11 commits into from
Jul 21, 2020
Merged

Update dtc/develop from NOAA-EMC develop 2020/07/21, prepare for SRW App #62

merged 11 commits into from
Jul 21, 2020

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Jul 21, 2020 •
edited
Loading

Update dtc/develop from NOAA-EMC develop 2020/07/21, and prepare for SRW App release. Changes in this PR:

  • Tom Black's dycore regional DA fix
  • Add flake model
  • Allow multiple regtest ecflow suites to run on the same server
  • Add PR, Issues for bugfix and feature request templates
  • Remove regression tests fv3_ccpp_gsd_sar_v1 and fv3_ccpp_rrfs_v0, add regression test fv3_ccpp_rrfs_v1beta_debug
  • Update several regression test configuration files (for cheyenne, orion, ...)

Associated PRs:

NCAR/GFDL_atmos_cubed_sphere#16
NCAR/ccpp-framework#313
NCAR/ccpp-physics#479
NCAR/fv3atm#61
#62

For regression testing, see below.

junwang-noaa and others added 8 commits July 14, 2020 15:11
@junwang-noaa
add Toms dycore regional DA fix (ufs-community#154)
7dbecbe 
* add Toms dycore regional DA fix
* update hera intel RT log files
* update fv3 with levp change
* upate baseline to develop-20200713
* copy regional control RESTART

Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com>
@DusanJovic-NOAA @MinsukJi-NOAA
Allow multiple regtest ecflow suites to run on the same server (ufs-c…
4ba1b72 
…ommunity#162)

* Allow multiple regtest ecflow suites to run on the same server
* implement running a single rt test
* Update 'usage' function in rt.sh (added -n option)

Co-authored-by: MinsukJi-NOAA <Minsuk.Ji@noaa.gov>
@aerorahul
Add PR, Issues for bugfix and feature request templates. (ufs-communi…
2833858 
…ty#167)

* add PR templates for feature and bugfix
Change-Id: Iad15dd1a584f4bd2fbaadf88359a55efd7b1925c
* add codeowners for automatic review requests
Change-Id: If6050e6411519223f514435801e09a63ed696a02
* Update CODEOWNERS
@climbfuji
Remove regression tests fv3_ccpp_gsd_sar_v1 and fv3_ccpp_rrfs_v0, add…
c08e814 
… regression test fv3_ccpp_rrfs_v1beta_debug
@climbfuji
Update .gitmodules and submodule pointer for fv3atm for code review a…
2c3e8d7 
…nd testing
@YihuaWu-NOAA
This is EMC flake model (ufs-community#164)
15124ee 
* This is EMC flake model
* Updated .gitmodules file under ufs-weather-model and tests/rt.conf
* Updated .gitmodules file under usf-weather-model
* Point to fv3 flake branch
* Updated ccpp_gfs_v16_flake_run.IN to use the new oro data for flake test
* Updated the following files and directories
* update to  the latest ccpp/physics branch
* Updated compile and regression test log files
* Updated ccpp-physics
* point to NOAA-EMC fv3 repo
@climbfuji
Merge branch 'develop' of https://github.com/ufs-community/ufs-weathe…
88735f4 
…r-model into prepare_for_srwapp_pr_20200720
@climbfuji
Add RRFS_v1beta tests to rt_orion.conf
22eebfb
This was referenced Jul 21, 2020
Merged
Merged
Merged
Merged
@climbfuji climbfuji marked this pull request as ready for review July 21, 2020 17:12
@climbfuji climbfuji requested a review from panll July 21, 2020 17:12
@climbfuji
Copy link
Collaborator Author

Regression testing on hera.intel and hera.gnu against existing EMC baseline using rt.conf: all tests pass except the newly added RRFS_v1beta tests ("missing baseline") - but both run to completion.

rt_hera_intel.log
rt_hera_gnu.log

@climbfuji
Copy link
Collaborator Author

Regression testing on cheyenne.gnu using rt_gnu.conf: first create new baseline, then move to final RTPWD location, then verify against it: all tests pass.

rt_cheyenne_gnu_create.log
rt_cheyenne_gnu_verify.log

@climbfuji
Copy link
Collaborator Author

Regression testing on cheyenne.intel using rt_intel.conf: first create new baseline, then move to final RTPWD location, then verify against it: all tests pass.

rt_cheyenne_intel_create.log
rt_cheyenne_intel_verify.log

llpcarson
llpcarson approved these changes Jul 21, 2020
View reviewed changes
Copy link

@llpcarson llpcarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@climbfuji
Copy link
Collaborator Author

Thanks, @llpcarson !

@climbfuji
Copy link
Collaborator Author

Regression testing on hera.intel using rt_ccpp_gsd.conf: first create new baseline, then move to final RTPWD location, then verify against it: all tests pass.

rt_ccpp_gsd_hera_intel_create.log
rt_ccpp_gsd_hera_intel_verify.log

@climbfuji climbfuji merged commit 8165575 into NCAR:dtc/develop Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llpcarson llpcarson llpcarson approved these changes

@grantfirl grantfirl Awaiting requested review from grantfirl

@panll panll Awaiting requested review from panll

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@climbfuji @llpcarson @junwang-noaa @DusanJovic-NOAA @aerorahul @YihuaWu-NOAA