Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a retry step to the flaky part of our CI workflow #581

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

kafitzgerald
Copy link
Collaborator

@kafitzgerald kafitzgerald commented Jan 9, 2024

Add a retry step to the flaky part (creating the HTML) of our CI workflow

Partially addresses #562.

I only added the retry step in ci.yml and not in the upstream-dev CI, since that doesn't seem to have the same problem. I think it's the additional data downloads from multiple version/OS CI runs that are problematic here and this works as a bandaid of sorts.

I am also leaving the issue open since I think we should look into some sort of caching strategy to really address this. That might need to wait a moment though as I'm pretty swamped.

@kafitzgerald kafitzgerald marked this pull request as draft January 10, 2024 15:36
@kafitzgerald
Copy link
Collaborator Author

I spoke too soon on the lack of trouble with the upstream-dev-ci. That just failed last night for a similar reason.

I'll add a retry step on that as well.

Copy link
Collaborator

@jukent jukent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this approach, we know if it is likely to time out sooner and can rerun it.

@jukent
Copy link
Collaborator

jukent commented Jan 10, 2024

Want to see if the retry solves our problems here before applying it to upstream-ci?

@kafitzgerald
Copy link
Collaborator Author

Want to see if the retry solves our problems here before applying it to upstream-ci?

Should have referenced it, but I was testing on my fork and the flaky step does time out and the retry step works.

I can turn this on again and link to it when I add the upstream ci bit.

@kafitzgerald
Copy link
Collaborator Author

Here are the links to the test runs on my fork:

CI Upstream: https://github.com/kafitzgerald/geocat-examples/actions/runs/7492946925
CI: https://github.com/kafitzgerald/geocat-examples/actions/runs/7492945543

The 3.11 ubuntu-latest CI run used the retry step - others just ran through.

@kafitzgerald kafitzgerald marked this pull request as ready for review January 11, 2024 19:41
@kafitzgerald kafitzgerald merged commit 51cd6e7 into NCAR:main Jan 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants