Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UFS-dev PR#22 #80

Merged
merged 4 commits into from
Jan 17, 2023
Merged

UFS-dev PR#22 #80

merged 4 commits into from
Jan 17, 2023

Conversation

grantfirl
Copy link
Collaborator

Identical to NOAA-EMC#600

SamuelTrahanNOAA and others added 3 commits December 20, 2022 10:31
* Enhanced stability of drag_suite module and added diagnostics

* Updated standard_names for do_gsl_drag_ls_bl, do_gsl_drag_ss, do_gsl_drag_tofd and ugwp_seq_update

* Assumed-shape in gwdps.f

* Added logical flag 'ugwp_seq_update' to gfs_physics_nml namelist

* Modified calculation of dtfac in drag_suite.F90 and revised various long_name's of diagnostic variables

* Removed passage of variables 'ak' and 'bk' to drag_suite -- these are no longer used

* Removed unused variables from GFS_typedefs.F90 and added clarifying comments in ccpp-physics
@grantfirl grantfirl requested a review from dustinswales January 3, 2023 23:01
@grantfirl
Copy link
Collaborator Author

Includes NOAA-EMC#605 (may have repercussions for ccpp-scm due to changes in FV3GFS_io -- need to check)

@dustinswales
Copy link
Collaborator

NOAA-EMC#605

@grantfirl I can take a look. Can you point me to where in the SCM that FV3GFS_io is ported?

@grantfirl grantfirl merged commit b334224 into NCAR:main Jan 17, 2023
@grantfirl
Copy link
Collaborator Author

NOAA-EMC#605

@grantfirl I can take a look. Can you point me to where in the SCM that FV3GFS_io is ported?

I think that the main places that may be impacted are in scm/src/scm_type_defs.90/physics_set() and in the UFS_IC_generator.py script. Both rely on the code in FV3GFS_io.F90/sfc_prop_restart_read() subroutine. I don't think that we need to switch to using the new copy_to... subroutines, but if there was any change in reading in variables or initializing them, that may need to be transferred over.

@dustinswales
Copy link
Collaborator

NOAA-EMC#605

@grantfirl I can take a look. Can you point me to where in the SCM that FV3GFS_io is ported?

I think that the main places that may be impacted are in scm/src/scm_type_defs.90/physics_set() and in the UFS_IC_generator.py script. Both rely on the code in FV3GFS_io.F90/sfc_prop_restart_read() subroutine. I don't think that we need to switch to using the new copy_to... subroutines, but if there was any change in reading in variables or initializing them, that may need to be transferred over.

@grantfirl I went through and I don't think there's anything in NOAA-EMC #605 that should change the i/o in the SCM. It seems that it is cleanup, no result changes? (I'm not terribly familiar with this part of the code)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants