-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UFS-dev PR#22 #80
UFS-dev PR#22 #80
Conversation
* Enhanced stability of drag_suite module and added diagnostics * Updated standard_names for do_gsl_drag_ls_bl, do_gsl_drag_ss, do_gsl_drag_tofd and ugwp_seq_update * Assumed-shape in gwdps.f * Added logical flag 'ugwp_seq_update' to gfs_physics_nml namelist * Modified calculation of dtfac in drag_suite.F90 and revised various long_name's of diagnostic variables * Removed passage of variables 'ak' and 'bk' to drag_suite -- these are no longer used * Removed unused variables from GFS_typedefs.F90 and added clarifying comments in ccpp-physics
Includes NOAA-EMC#605 (may have repercussions for ccpp-scm due to changes in FV3GFS_io -- need to check) |
@grantfirl I can take a look. Can you point me to where in the SCM that FV3GFS_io is ported? |
I think that the main places that may be impacted are in scm/src/scm_type_defs.90/physics_set() and in the UFS_IC_generator.py script. Both rely on the code in FV3GFS_io.F90/sfc_prop_restart_read() subroutine. I don't think that we need to switch to using the new |
@grantfirl I went through and I don't think there's anything in NOAA-EMC #605 that should change the i/o in the SCM. It seems that it is cleanup, no result changes? (I'm not terribly familiar with this part of the code) |
Identical to NOAA-EMC#600