Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning fixes: Github Actions Updates #562

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

scrasmussen
Copy link
Member

Changes to fix warnings from Github CI runs.

  • Change all to latest Ubuntu runner option, 20.04 is being deprecated
  • Simplifying test names
  • Cache misses from previous naming scheme

@scrasmussen scrasmussen force-pushed the warning-fix/ubuntu-runner-update branch 2 times, most recently from e0269b3 to 523737d Compare February 20, 2025 05:34
Copy link
Collaborator

@dustinswales dustinswales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes. I had a few minor suggestions.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we know this test will always fail, should we turn if off? Or at least to only run on workflow_dispatch?
(I really hate the red x!!!)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed! Will turn it off

@@ -1,19 +1,19 @@
name: CI test to build the CCPP-SCM on ubuntu v22.04
name: build the CCPP-SCM on ubuntu v22.04
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought v20.04 is being sunset, not v22.04?
Anyways, we're using the latest version now. Remove version number from name

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out! In the same vein, what are people's thoughts on changing ci_build_scm_ubuntu_22.04.yml to ci_build_scm_ubuntu.yml and using the latest runner? I'm a fan of generally using the latest because if it breaks something I'd like to know about it before the users run into it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do it!

…ntu runner option, 20.04 is being deprecated. Simplifying test names. Bumping Python version for latest-runner
@scrasmussen scrasmussen force-pushed the warning-fix/ubuntu-runner-update branch from 523737d to a32a316 Compare February 20, 2025 18:29
…ration since we don't have them to test with. Updating NVIDIA HPC SDK release. Bumping Python versions
@scrasmussen scrasmussen force-pushed the warning-fix/ubuntu-runner-update branch 3 times, most recently from 9cf3bd6 to 9717af8 Compare February 20, 2025 20:13
@scrasmussen scrasmussen force-pushed the warning-fix/ubuntu-runner-update branch from 9717af8 to 38c4c5e Compare February 20, 2025 20:15
@scrasmussen scrasmussen marked this pull request as draft February 20, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants