-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warning fixes: Github Actions Updates #562
base: main
Are you sure you want to change the base?
warning fixes: Github Actions Updates #562
Conversation
e0269b3
to
523737d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these changes. I had a few minor suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we know this test will always fail, should we turn if off? Or at least to only run on workflow_dispatch?
(I really hate the red x!!!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed! Will turn it off
@@ -1,19 +1,19 @@ | |||
name: CI test to build the CCPP-SCM on ubuntu v22.04 | |||
name: build the CCPP-SCM on ubuntu v22.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought v20.04 is being sunset, not v22.04?
Anyways, we're using the latest version now. Remove version number from name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out! In the same vein, what are people's thoughts on changing ci_build_scm_ubuntu_22.04.yml
to ci_build_scm_ubuntu.yml
and using the latest runner? I'm a fan of generally using the latest because if it breaks something I'd like to know about it before the users run into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do it!
…ntu runner option, 20.04 is being deprecated. Simplifying test names. Bumping Python version for latest-runner
523737d
to
a32a316
Compare
…ration since we don't have them to test with. Updating NVIDIA HPC SDK release. Bumping Python versions
9cf3bd6
to
9717af8
Compare
9717af8
to
38c4c5e
Compare
Changes to fix warnings from Github CI runs.