-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge v3.0 with master #125
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update v3.0 with PR 108 (and update submodule pointers)
…otifies a user that a subprocess has exited abnormally
multi_run_gmtb_scm.py ERROR notification for users
Change where physics data is copied to run directory
Finish U/G for v3.0
update submodule pointers
minor edits to U/T guide following @ligiabernardet suggestions
add -m 0 option to NCEPlibs installation script options list
update README.md
… code' sections be consistent
Clarifying v3.0 vs master
… text to be able to set machine-specific flags; this fixes ccpp-framwork issue NCAR#190 when CFLAGS=-I/opt/local/include on grantfirl's machine with macports-installed libxml2 v2.9.9
…o staged data in raw_case_input; put extra flags from CMakeLists.txt into pjpegion setup script; note: without flags, execution stops prematurely -- address in followup commit
…sts.txt and into a machine-specific setup script for pjpegion; note that -finit-real=nan is now needed for runs to complete in release mode; check on initializations issues in a followup PR
Fix libxml2 v2.9.9 compilation failure
… and other needed python packages
… -finit-real=nan requirement in CMakeLists.txt by properly filling out the levels dimension in the case netCDF file; modified extract_FV3GFS_column_ic.py to calculate the pressure levels
Edits to pjpegion/pjpegion for inclusion into NCAR/v3.0
updated NCEPLIBS_DIR in Cheyenne setup scripts for GNU and Intel
… and ccpp-framework; add back files in ccpp_prebuild_config.py; chamge lsm namelist variable to 3 for GSD suite; remove sfc_sice_post from SDFs; sync gmtb_scm_type_defs.f90 and GFS_typedefs.F90 in scm/src with GFS_typedefs.F90 from NEMSfv3gfs
Associated PR: NCAR/ccpp-physics#290 |
grantfirl
commented
Jul 29, 2019
@@ -2,34 +2,33 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many whitespace changes were included to sync up with GFS_typedefs.F90 from FV3 to make looking at future changes easier.
Tested (and working) with Mac/Theia/Cheyenne with Intel/GNU and Release/Debug. Should be good to merge. |
climbfuji
approved these changes
Jul 30, 2019
dustinswales
pushed a commit
to dustinswales/ccpp-scm
that referenced
this pull request
May 16, 2022
Merge v3.0 with master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to merge the v3.0 branch into the master branch. Some of v3.0 changes include:
Changes put into the v3.0 branch (but not released with v3.0) include Phil Pegion's changes to load FV3 cold-start ICs for initializing surface variables. This included changes to CMakeLists.txt and several files in scm/src.
This branch was further updated to work with the gmtb/develop branches of ccpp-physics and ccpp-framework. These changes include: