ccpp-physics Thompson HRRR aerosol debugging, finalize routine, idempotence of _init/_finalize #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inalize that deallocates the allocatable arrays, fix for reading precomputed tables: if checksum does not match, delete file before trying to create it
… to test if mp_thompson_hrrr was initialized or not (needed to make _init and _finalize idempotent
|
@grantfirl @llpcarson would it be possible for you to review this PR and https://github.com/NCAR/FV3/pull/13 so that I can merge them? The code doesn't change the results of any of the other tests and produces reasonable results (by eyeballing) for the HRRR Thompson MP scheme without/with aerosols, compared to the existing Thompson MP scheme in gfsphysics (older version, no aerosols, some mistakes in porting it over). |
uturuncoglu
pushed a commit
to uturuncoglu/ccpp-physics
that referenced
this pull request
Sep 18, 2023
Adding OpenACC statements to accelerate MYNN surface scheme performance through GPU offloading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
mp_thompson_hrrr_initandmp_thompson_hrrr_finalizeidempotent and to test inmp_thompson_hrrr_runif scheme is initializedThis Pr does not change the results and was tested on MacOSX with clang/gfortran.