Fixed a bug related to sensible/latent heat fluxes for AQM coupling (Issue#945) #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n GFS_PBL_generic_post.F90
This was referenced Aug 17, 2022
|
Does anyone know if @rmontuoro (the original author of this section) agrees with the solution? |
grantfirl
approved these changes
Aug 17, 2022
|
@grantfirl Maybe we should invite Raffaele to review this code change. |
|
@ChunxiZhang-NOAA, @grantfirl - Thanks. I will take a look and get back to you. |
|
The proposed changes do not address the lack of surface net heat fluxes over land, which need to be provided to AQM. A new formulation is proposed in PR #953. |
|
@ChunxiZhang-NOAA @rmontuoro Should we close this (and upstream PRs) in favor of merging #953 (and upstream PRs)? |
|
@grantfirl We can close this PR. |
|
Closing this PR in favor of continuing discussion of the solution in #953 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug is fixed which is described in Issue#945.
Currently, this PR only fixed the bug that caused model crashes due to the unallocated variables dtsfc_cice and dqsfc_cice which are only allocated when cplflx=.true. in GFS_typedefs.F90.
There are potential other issues. For instance, when (cplaqm .and. .not.cplflx) is ture, dtsfci_cpl and dqsfci_cpl are only assigned values over ocean (e.g., oceanfrac > 0).