Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dtc/hwrf-physics: combined version of HAFS/GFS moninedmf scheme (hybrid EDMF PBL) #428

Merged
merged 5 commits into from
Apr 7, 2020
Merged

dtc/hwrf-physics: combined version of HAFS/GFS moninedmf scheme (hybrid EDMF PBL) #428

merged 5 commits into from
Apr 7, 2020

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Apr 6, 2020 •
edited
Loading 

    git cherry-pick 942889ab0acace519254712cb4e14b6aaf3e0415
    git cherry-pick 500d53a21027f362a9c12c10767f0b4f8cf3361c
    git cherry-pick b0f04b210bd588673182023ea36b56ee94642c3e
    git cherry-pick e895c62cf49b908927678d72c1ad21ad828e3587
  • apply changes for moninedmf.{f,meta} hidden in update of code from dtc/develop (0ae7516)

Associated PRs:

#428
NCAR/fv3atm#37
NCAR/ufs-weather-model#35

For regression testing information, see NCAR/ufs-weather-model#35

@climbfuji climbfuji changed the base branch from master to dtc/hwrf-physics April 6, 2020 16:37
This was referenced Apr 6, 2020
Merged
Merged
@climbfuji climbfuji marked this pull request as ready for review April 6, 2020 17:21
@grantfirl
Copy link
Collaborator

Cherry-picked commits look good here too.

grantfirl
grantfirl approved these changes Apr 6, 2020
View reviewed changes
Copy link
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but someone other than me should take a look.

@climbfuji
Copy link
Collaborator Author

I must have missed something, this is the compile error I get

[ 24%] Building Fortran object FV3/ccpp/physics/CMakeFiles/ccppphys.dir/physics/cu_gf_sh.F90.o
[ 24%] Building Fortran object FV3/ccpp/physics/CMakeFiles/ccppphys.dir/physics/moninedmf.f.o
/scratch1/BMC/gmtb/Dom.Heinzeller/ufs-weather-model/ufs-weather-model-support-hafs-20200403/rt/FV3/ccpp/physics/physics/moninedmf.f(778): error #6404: This name does not have a type, and must have an explicit type.   [SPDKW]
              wspm(i,1) = spdkw/0.6  ! now the Km limit for 500 m.  just store in K=1
--------------------------^
compilation aborted for /scratch1/BMC/gmtb/Dom.Heinzeller/ufs-weather-model/ufs-weather-model-support-hafs-20200403/rt/FV3/ccpp/physics/physics/moninedmf.f (code 1)
make[3]: *** [FV3/ccpp/physics/CMakeFiles/ccppphys.dir/physics/moninedmf.f.o] Error 1
make[2]: *** [FV3/ccpp/physics/CMakeFiles/ccppphys.dir/physics/moninedmf.f.o.provides] Error 2
make[2]: *** Waiting for unfinished jobs....

Will look again after my lunch break ...

@grantfirl
Copy link
Collaborator

Looks like you'll need this too:
grantfirl@0ae7516#diff-fd78704fdde7548a16d186da938e1bda

@climbfuji
Copy link
Collaborator Author

I think my work on this is a review as well, will go ahead and merge.

@climbfuji climbfuji merged commit 0346c38 into NCAR:dtc/hwrf-physics Apr 7, 2020
@climbfuji climbfuji mentioned this pull request Apr 7, 2020
Closed
@climbfuji climbfuji deleted the dtc-hwrf-physics-add-moninedmf branch June 27, 2022 03:11
hannahcbarnes pushed a commit to hannahcbarnes/ccpp-physics that referenced this pull request Aug 3, 2022
@dustinswales
Changes to FV3 for ccpp-physics NCAR#782 (NCAR#428)
86d4bb3 
This PR contains changes to the RRTMGP code in the ccpp-physics PR#782.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grantfirl grantfirl grantfirl approved these changes

@llpcarson llpcarson Awaiting requested review from llpcarson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@climbfuji @grantfirl