Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further code cleanup for SCM and FV3 #251

Merged
merged 4 commits into from
May 24, 2019

Conversation

grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented May 23, 2019

These changes clean up the following:

  • Fortran 2018 deleted feature warnings in GNU 9.1 for cu_gf_deep.F90 and module_sf_ruclsm.F90 (Fortran 77 shared do loop endings and do loop ending that is neither continue or end do)
  • Uninitialized intent(out) variable warnings in Intel 18: cu_gf_driver.F90, cu_ntiedtke.F90, module_gfdl_cloud_microphys.F90, mp_thompson_post.F90, satmedmfvdif.F
  • division by zero in an if test and an extraneous operator (+) in micro_mg3_0.F90
  • different logical argument types in sfcsub.F
  • remove comment about HYBRID CCPP mode (see https://github.com/NCAR/NEMSfv3gfs/pull/162 for a description)

These need to be put through regression tests in FV3, which will be done as part of @climbfuji work to remove the hybrid build.

These changes also form a subset of the branch ccpp_release_3_work that is required to work with the SCM.

…_cleanup

Remove HYBRID build - merge into two_host_cleanup_320190523
Copy link
Collaborator Author

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs approval by @climbfuji or @llpcarson since it originated with me.

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. These changes have been tested with NEMSfv3gfs (see associated PRs listed in the comments).

@climbfuji climbfuji merged commit 65a7f94 into NCAR:master May 24, 2019
@grantfirl grantfirl mentioned this pull request May 29, 2019
grantfirl added a commit to grantfirl/ccpp-physics that referenced this pull request Feb 14, 2025
Merge NCAR:main to ufs-community:ufs/dev + update GF/C3 for SRW3.0 release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants