Update and cleanup of H2O, O3, sfc_sice and others #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…physics (portability changes)
…gument, remove non-CCPP legacy code
…sphysics (documentation only)
|
Regression test logs for CCPP-ref and CCPP tests: |
|
@mzhangw EMC made some changes to the documentation in sfc_sice.f, most of which was either copied from your work or made redundant by your work for CCPP release v1. I only updated the documentation for two of the variables in the argument list. Can you please check that this is ok? |
|
Look good to me. Thanks!
Man
… On Jul 12, 2018, at 6:35 PM, Dom Heinzeller ***@***.***> wrote:
@mzhangw <https://github.com/mzhangw> EMC made some changes to the documentation in sfc_sice.f, most of which was either copied from your work or made redundant by your work for CCPP release v1. I only updated the documentation for two of the variables in the argument list. Can you please check that this is ok?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#120 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Ab87akLsbuRdimAZtewjOd3-r08KXCuYks5uF4jngaJpZM4VNbKO>.
|
|
Regression test log of standard regression tests (non-CCPP build): |
|
Update, also works with SCM and doesn't change the results. |
hannahcbarnes
pushed a commit
to hannahcbarnes/ccpp-physics
that referenced
this pull request
Aug 3, 2022
…velop_20211215 Update gsl/develop from develop 2021/12/15
dustinswales
added a commit
to dustinswales/ccpp-physics
that referenced
this pull request
Nov 17, 2023
updates to MYNN-EDMF and Thompson
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates a number of files with the changes made between FV3v0 and the current master on VLAB/Github. These changes are mostly for the documentation, but include some bugfixes in h2ointerp.f90 and ozinterp.f90, and some portability changes in machine.F
physics/h2ointerp.f90
physics/machine.F
physics/ozinterp.f90
physics/set_soilveg.f
physics/sfc_sice.f
The PR also contains some cleanup work in physics/memcheck.F90 (a memory diagnostics utility that is not used in operations) to use the model-provided MPI communicator instead of MPI_COMM_WORLD.
These results do not change the answer, tested on Theia/Intel (CCPP-ref and CCPP tests completed; the standard, non-CCPP tests are still running, but since the changes only affect ccpp/physics there will be no difference).