Fix for ccpp_track_variables.py: Need "recursive=True" for glob on .meta files #581
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the change in directory structure for CCPP physics (ufs-community/ccpp-physics#99), there are now
.meta
files at different levels in the directory tree. Theccpp_track_variables.py
script needs the location of these.meta
files as an input argument to the script, but the call toglob.glob
in the script does not use therecursive=True
argument, so even if the user passes in the argument-m './physics/physics/**/'
(which should include all subdirectories), the call toglob.glob
only searches one level. Our simple test case only has.meta
files at a single directory level, so we never caught this issue.Simply adding the
recursive=True
argument fixes this issue.User interface changes?: No
Fixes: #580 ccpp_track_variables.py is broken since CCPP physics directory structure was reorganized
Testing:
test removed: none
unit tests: Passing
system tests: none
manual testing: See Issue #580