Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Recover answer change from CFC PR #191

Merged

Conversation

gustavo-marques
Copy link
Collaborator

In a previous PR, the expression

tr(i,j,1) = (b1(i)*h_tr)*tr(i,j,1) + sfc_src(i,j)

was changed to

tr(i,j,1) = b1(i)*(h_tr*tr(i,j,1) + sfc_src(i,j))

in 4 lines. This changed the order in which b1(i)*h_tr*tr(i,j,1) is evaluated,
even if sfc_src(i,j) = 0.0. Currently, the CESM configurations use the
passive tracer tridiagonal solver for T and S. Therefore, the modification above changed
answers in these configurations. To recover previous answers the expression must
be

tr(i,j,1) = (b1(i)*h_tr)*tr(i,j,1) + b1(i)*sfc_src(i,j)

which is what is implemented in the current PR.

The answers obtained before #189 will be recovered.
Thanks to @klindsay28 for sorting this out.

In a previous commit, the expression

tr(i,j,1) = (b1(i)*h_tr)*tr(i,j,1) + sfc_src(i,j)

was change to

tr(i,j,1) = b1(i)*(h_tr*tr(i,j,1) + sfc_src(i,j))

in 4 lines. This changed the order in which b1(i)*h_tr*tr(i,j,1) is evaluated,
even if sfc_src(i,j) is 0.0. Because the CESM configurations use the
passive tracer tridiagonal solver for T and S, the modification above changed
answers in these configurations. To recover previous answers the expression must
be

tr(i,j,1) = (b1(i)*h_tr)*tr(i,j,1) + b1(i)*sfc_src(i,j)
@gustavo-marques gustavo-marques changed the title Recover answer change from CFC PR * Recover answer change from CFC PR Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants