* Recover answer change from CFC PR #191
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous PR, the expression
tr(i,j,1) = (b1(i)*h_tr)*tr(i,j,1) + sfc_src(i,j)
was changed to
tr(i,j,1) = b1(i)*(h_tr*tr(i,j,1) + sfc_src(i,j))
in 4 lines. This changed the order in which
b1(i)*h_tr*tr(i,j,1)
is evaluated,even if sfc_src(i,j) = 0.0. Currently, the CESM configurations use the
passive tracer tridiagonal solver for T and S. Therefore, the modification above changed
answers in these configurations. To recover previous answers the expression must
be
which is what is implemented in the current PR.
The answers obtained before #189 will be recovered.
Thanks to @klindsay28 for sorting this out.