Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ocean_model_data_get back into config_src/coupled_driver #138

Merged

Conversation

gustavo-marques
Copy link
Collaborator

@gustavo-marques gustavo-marques commented Jan 6, 2020

ocean_model_data_get* was deleted from all the caps since it was determined these are no longer needed (see #133). When running the full GFDL tests, I realized the GFDL coupler needs these subroutines in config_src/coupled_driver. This patch reverts commit #133 then removes ocean_model_data_get from MCT and NUOPC caps.

Fixes #137

@codecov-io
Copy link

codecov-io commented Jan 6, 2020

Codecov Report

Merging #138 into dev/ncar will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           dev/ncar     #138   +/-   ##
=========================================
  Coverage     43.36%   43.36%           
=========================================
  Files           213      213           
  Lines         62694    62694           
=========================================
  Hits          27185    27185           
  Misses        35509    35509

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c358114...f7debed. Read the comment docs.

@alperaltuntas alperaltuntas merged commit 44d36c4 into NCAR:dev/ncar Jan 7, 2020
@gustavo-marques gustavo-marques deleted the fix_ocean_model_data_get branch May 5, 2020 15:00
alperaltuntas pushed a commit to alperaltuntas/MOM6 that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ocean_model_data_get should have not been deleted from GFDL's cap
3 participants