-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qceff dartlab #740
qceff dartlab #740
Conversation
THis involved adding optional arguments to return information about the weights in the prior and posterior bins to obs_increment_rhf.m
…ne the pdf for a bounded normal rank histogram given the ensemble members and information about the tail normals.
distribution plot is updated whenever the buttons selecte a new distribution.
…instead of using hard coded bounds from oned_ensemble's axes.
…se where bnrh is bounded on the left at 0. oned_ensemble is believed to be working for all cases with the improved plotting. bounded_oned_ensemble is believed to be functioning correctly except for the case of applying inflation with the gamma or BNRH distributions.
in which the inflated prior mean value was not being correctly computed. This was also changed in oned_ensemble.m where it did not produce a wrong answer (since inflated mean is always the same as prior mean) but could have led to a misunderstanding when looking at the code.
These are directly modified versions of the fortran routines of the same names. They include slightly less error checking at the moment and should be further polished for use in actual matlab assimilations as opposed to graphical demonstrations. These have been tested for direct inversion and appear to be bitwise for the small cases tested.
…unction weighted_norm_inv.m out of obs_increment_rhf.m since it is needed for the recently added cdf and inverse cdf of the bnrh. All inflation variants now work in bounded_oned_ensemble.
exisiting guis can use it without modification.
an additional plot box for the transformed ensemble and new button for the unobserved variable transform.
that observed variable is nonnegative. Put in appropriate error handling if a negative value is clicked. Fixed the error messages for the observation and obs error sd specification.
… and updates in the ppi joint plot.
…ies. The PPI space plots are now appropriately cleared in the same fashion as the standard state space.
…rved variable. Added PPI transforms for the observed variable. Options limited to normal and unbounded RH since the observed variable is unbounded in this demonstration.
distribution. Made correct use of SCALAR function for transforming observed posterior with BNRH.
…nd the existing oned_ensemble.m and twod_ensemble.m
… from the update_ens callback. Updates the observation at each cycle and plots the updated obs, prior and posterior.
…ation of the continuous mean and sd.
and associated call backs to 'Cycle DA'
the dynamically changeable growth rate.
first become meaninful.
the continuous distributions with solid curves. Added approximate fitted continuous distributions for the EnKF for comparison.
so that just the 1D KF can be seen.
the continuous and ensemble pdfs.
Understood. I've iterated with Kevin on my revisions and there is a need
for a few minor additional changes to section 5. As soon as those are done,
will finish up the pull request on the pdfs and share the pptxs with Helen.
…On Tue, Jan 14, 2025 at 10:54 AM Helen Kershaw ***@***.***> wrote:
still waiting on pptx slides
—
Reply to this email directly, view it on GitHub
<#740 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANDHUIVUOOZDYTLC2CS27MD2KVFM5AVCNFSM6AAAAABO3N54YSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJQG4YTSMJVHA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
not with Helen, with the team! 🤦♀️ |
section 4 is a different size (widescreen) |
Section 4 is a different size since it was adapted from new slides. For
now, the labor to make the format consistent across sections is too great
to be justified and this is not planned for the impending release. If the
new style guidelines are significantly different, we may consider
reformatting at that time.
…On Tue, Jan 21, 2025 at 10:27 AM Helen Kershaw ***@***.***> wrote:
section 4 is a different size (widescreen)
—
Reply to this email directly, view it on GitHub
<#740 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANDHUIULIG5DYMH27CU7PJL2LZ7PTAVCNFSM6AAAAABO3N54YSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBVGMZTQNZWHE>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
@jlaucar put the power points in this google drive folder: |
added auto converted slides to https://drive.google.com/drive/folders/1F8XxwmYySjJVwYezZPHJRz_qjedR9X6q as a backup |
…dated DART_LAB matlab scripts.
Here are responses to Kevin's comments on all 5 sections. These have been implemented and Kevin has reviewed the revisions. Reponses to Kevins’ comments Section 1: I'll stop trying to make all the notation consistent with my limited understanding. 1:2 It would fit the picture better to use a red line at 1 C to represent the ob, 1:3 I think the picture is a little misleading. I'd omit the star (or line), 1:4 The likelihood equation would be easier for me to read if it were 1:9 The notation here implies to me that this distribution is some kind of inversion of the likelihood. Section 2 I'm suggesting a lot of notation changes. 2:2 "additional variable" ->? "unobserved additional variable" Section 3 Section 4 4:6 This equation isn't used in the rest of the slides, so maybe it's not worth making the notation consistent. Section 5 Again, I'm suggesting notation changes. Tell me if I should implement any of them
|
There were a few more updates to Section 5, handled via email: 5.16 nitpick; lnr -> ln(r) 5.28 I see that -1 is now inside the sqrt. These are all fixed. Jeff asked me to review and approve this PR, but I should note that I have read through the responses to Sections 1-4, but not the updated slides. Do I need to review the slides? |
Powerpoints have been uploaded to this folder.
…On Tue, Jan 21, 2025 at 10:55 AM Helen Kershaw ***@***.***> wrote:
@jlaucar <https://github.com/jlaucar> put the power points in this google
drive folder:
https://drive.google.com/drive/folders/1F8XxwmYySjJVwYezZPHJRz_qjedR9X6q
—
Reply to this email directly, view it on GitHub
<#740 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANDHUIRR6MD2N4LWW6D4TE32L2CZHAVCNFSM6AAAAABO3N54YSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBVGM4TIMZQGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Not sure if this is a question for me, but here is my 2 cents. We're at 6 months to get access to the ppt slides, so no one other than Jeff has been able to make changes in that time. The code has been used by students at a workshop, but not reviewed. So I'll leave it up to your judgment what you need to review for slides for this pull request. Cheers, |
Kevin,
Quickly check the slides to make sure there weren't any conversion errors,
but don't do a complete check again. I went thru all of them yesterday in
about an hour looking for formatting and other problems.
This is expected to be the last revision of these slides in PDF form,
caveat correction of any bugs that appear subsequently. There will be
additional PDFs in a pull request for section 6 that I discussed in the
standup yesterday.
…On Wed, Jan 22, 2025 at 7:22 AM Helen Kershaw ***@***.***> wrote:
Jeff asked me to review and approve this PR, but I should note that I have
read through the *responses* to Sections 1-4, but not the updated slides.
Do I need to review the slides?
Not sure if this is a question for me, but here is my 2 cents. We're at 6
months to get access to the ppt slides, so no one other than Jeff has been
able to make changes in that time. The code has been used by students at a
workshop, but not reviewed. So I'll leave it up to your judgment what you
need to review for slides for this pull request.
If this is important in your decision on what to review- this will be the
last pull request where we take new pdfs. Only fixes to existing slides
going forwards, then removal of pdfs.
Cheers,
Helen
—
Reply to this email directly, view it on GitHub
<#740 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANDHUIUFX4LKESJDU7KR2X32L6STNAVCNFSM6AAAAABO3N54YSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBXGM4DCNBVGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
looking forward to seeing the .rst for the dart tutorial! |
I think that the .rst has been updated in the current pull request?
…On Wed, Jan 22, 2025 at 7:46 AM Helen Kershaw ***@***.***> wrote:
looking forward to seeing the .rst for the dart tutorial!
—
Reply to this email directly, view it on GitHub
<#740 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANDHUIXUQUUTZYEW4PQZQKT2L6VM7AVCNFSM6AAAAABO3N54YSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBXGQ2DENZZGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
forget it, it is I joke. I will try to be less funny in the future. |
Here are my notes from reviewing the pdfs, which I fetched from the NCAR/DART qceff_dartlab this morning. 1.29 1.9 and 1.10 define the normals using sigma^2, while this page uses just sigma. 1.45 t_O -> T_O or T_{O,2} 2.43 I was under the impression that a smoother uses data 2.48 Should the state operated on by m^hat be an extended state vector (x^hat_{t_k})? 3 No fixes needed 4 No fixes needed |
Kevin,
Nice work. It seems that it is impossible to actually get all of the errors
out of something like this.
Your comments on the parameters of the normal distribution in Section 1 are
spot on. Both notations are used, but we have to pick one. The very
earliest slides here were actually created in 2002 I believe, with the old
framemaker software. At that point, we were using notation recommended by
Doug Nychka. Later, we switched to being consistent with papers being
published in MWR and subsequently we rely on Wikipedia for stochastic
notation. I have attempted to switch all cases of the old use of the s.d.
to the new use of the variance. I also simplified the equations for
computing the variance since we no longer need to take square roots for
notation. I found one other instance that you missed and corrected that. I
also checked all of the other sections again and it looks like they are all
consistent with what we should be doing.
I believe your concerns about section 2 are not a problem. Please check
again on the smoother, but I believe it says that x is being estimated at a
time less than the latest observations at time tk, so obs in the future.
The arguments to the model advance can be written compactly just with the
original state x since it is trivial to compute the extended state when one
gets to that stage. However, the function does generate the extended state.
To try to avoid packing lots of pdf revisions into github, I'll share the
updated section 1 pdf with you in another email. Please check the updates
one more time. Thanks, Jeff
…On Wed, Jan 22, 2025 at 10:31 AM kdraeder ***@***.***> wrote:
Here are my notes from reviewing the pdfs, which I fetched from the
NCAR/DART qceff_dartlab this morning.
1.29 1.9 and 1.10 define the normals using sigma^2, while this page uses
just sigma.
Does it matter?
1.44 is like 1.29
1.52 is like 1.29
1.45 t_O -> T_O or T_{O,2}
1.46 same
------------------------------
2.43 I was under the impression that a smoother uses data
from before and after the time of interest.
2.48 Should the state operated on by m^hat be an extended state vector
(x^hat_{t_k})?
2.50 (3),(4) same
------------------------------
3 No fixes needed
------------------------------
4 No fixes needed
—
Reply to this email directly, view it on GitHub
<#740 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANDHUIRF5K7PDHKWGLNU55T2L7IVXAVCNFSM6AAAAABO3N54YSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBXHA2DSNJQGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Section 1 of DART_LAB.
The fixes requested by Kevin in section 1 have been pushed and the powerpoint files have been updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As Jeff pointed out, it will likely never be perfect, but we made a lot of progress in that direction.
In my view the biggest improvement we might make may need to wait until the notation conventions of the community for conditional probabilities, error functions, likelihoods, etc. settle on something that's unambiguous and straightforward for students to use.
Kevin
Description:
DARTLAB qceff from Jceff
Fixes issue
Fixes #739
Note the slides are not in this pull request (yet!)
Types of changes
Documentation changes needed?
Tests
Run by a group of workshop attendees at AGOS 2024
Checklist for merging
Checklist for release
Testing Datasets