Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pangu-DART interface to support DA with ensemble ML models #737

Merged
merged 13 commits into from
Jan 23, 2025

Conversation

Nuo-Chen
Copy link
Contributor

Description:

Adding Pangu-DART interface to support DA with ensemble ML models.

Fixes issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

Please describe any tests you ran to verify your changes.

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

Testing reanalysis dataset at /glade/work/chennuo/code/pangu/dart_pangu/era5_data/
Testing observation data at /glade/work/chennuo/code/cice_old/DART/observations/obs_converters/NCEP/prep_bufr/data/20240120/prepout

@hkershaw-brown hkershaw-brown changed the title initial commit Pangu-DART interface to support DA with ensemble ML models Sep 25, 2024
@hkershaw-brown
Copy link
Member

Thanks for this Nuo!

hkershaw-brown and others added 5 commits September 26, 2024 14:20
fprettify --disable-indent-mod  models/pangu/model_mod.f90
Removed non-existant (and unused) module
Set Character lengths equal in array constructors
@hkershaw-brown
Copy link
Member

note on AI models, no terrain surface - problems for altimeter obs.

@criedel40
Copy link
Collaborator

criedel40 commented Nov 8, 2024 via email

@hkershaw-brown
Copy link
Member

Chris come back to dares! We were talking about this at the standup, reading in terrain from another source.
We've got two pangu projects on the go, and I think we're going to hit a few things (e.g. terrain) that apply to AI atmosphere models in general.

@criedel40
Copy link
Collaborator

criedel40 commented Nov 8, 2024 via email

@Nuo-Chen
Copy link
Contributor Author

Nuo-Chen commented Nov 8, 2024

I think convert_pgout_to_nc.py reads in terrain.npy, though the path was linked to my work directory. terrain.npy and landmask.npy are located in model/pangu, both are created them with WRF-WPS.

@hkershaw-brown
Copy link
Member

awesome thanks Nuo!

@hkershaw-brown
Copy link
Member

hkershaw-brown commented Jan 16, 2025

@HKershaw link to Nuo's AMS poster in release notes

Nuo-Chen and others added 3 commits January 21, 2025 18:03
remove register_module (does nothing)
remved unused modules (sort, typesizes -not needed with netcdf)
@hkershaw-brown hkershaw-brown added release+1 bundle with release after next release! bundle with next release and removed release+1 bundle with release after next labels Jan 22, 2025
Copy link
Member

@hkershaw-brown hkershaw-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Thanks again for this Nuo!

@hkershaw-brown hkershaw-brown merged commit 7784ed0 into NCAR:main Jan 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release! bundle with next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants