Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix misplaced comment about writing an obs_seq file #508

Merged
merged 1 commit into from
Jul 27, 2023
Merged

fix misplaced comment about writing an obs_seq file #508

merged 1 commit into from
Jul 27, 2023

Conversation

nancycollins
Copy link
Collaborator

Description:

i was looking for something else and noticed a misleading comment in filter_mod

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (code comment)

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

I compiled lorenz 96 and ran it.

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

@hkershaw-brown hkershaw-brown added the release! bundle with next release label Jul 18, 2023
@hkershaw-brown
Copy link
Member

@hkershaw-brown bundle with next release.
NB: change the base of this pull request

@hkershaw-brown hkershaw-brown changed the base branch from main to mom6-time July 27, 2023 19:03
@hkershaw-brown hkershaw-brown merged commit d06220e into mom6-time Jul 27, 2023
@hkershaw-brown hkershaw-brown deleted the filter_comment_fix branch July 27, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkershaw-brown hkershaw-brown hkershaw-brown approved these changes

Assignees
No one assigned
Labels
release! bundle with next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nancycollins @hkershaw-brown