fix: intent(inout) for close_X_dist and close_X_ind

[hkershaw-brown]

Description:

Added intent(inout) to get_close_X_dist and get_close_X_ind array for get_close_X_caching .

Currently giving correct answers, but intent(out) is undefined
on entry to the subroutine according to Fortran standard

Fixes issue

Addition to pull request #368
original isse #364

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update

Documentation changes needed?

• My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Tests

Please describe any tests you ran to verify your changes.
Bitwise wrf.

Checklist for merging

• Updated changelog entry
• Documentation updated
• Version tag

Testing Datasets

• Dataset needed for testing available upon request
• Dataset download instructions included
• No dataset needed

[mjs2369]

@hkershaw-brown looks good. I went ahead and compiled and ran with debugging flags on gfortran for the previous commit that doesn't incorporate these changes, and it didn't even produce a warning for the intent(out). It's odd, but it won't matter once these changes are implemented.

[hkershaw-brown]

Thanks Marlee, I'll get this released with Moha's bug fix #375 shortly.

If you are curious it might be worth writing a 'hello world' test with intent(out) to see what warnings you can generate.