Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

state structure has not been tested yet with new naming conventions. #106

Closed
hkershaw-brown opened this issue Dec 24, 2020 · 3 comments · Fixed by #779
Closed

state structure has not been tested yet with new naming conventions. #106

hkershaw-brown opened this issue Dec 24, 2020 · 3 comments · Fixed by #779
Assignees
@hkershaw-brown
Labels
Bug Something isn't working dead-code code not used or does nothing IO IO refactoring notes and issues state_structure notes on refactoring of state_structure_mod Test Improves testing capabilities

Comments

@hkershaw-brown
Copy link
Member

Message when running test_state_structure:

 ERROR FROM:
  test_state_structure
  routine: test_state_structure
  message: Has not been tested yet with new naming conventions.
@hkershaw-brown hkershaw-brown added the Bug Something isn't working label Dec 24, 2020
@hkershaw-brown hkershaw-brown self-assigned this Dec 24, 2020
hkershaw-brown pushed a commit that referenced this issue Jan 4, 2021
@timhoar
Merge pull request #106 from timhoar/gmi_download_instructions
597af97 
GMI (radiance observations) download instructions
@hkershaw-brown hkershaw-brown added the Test Improves testing capabilities label Jan 12, 2021
@hkershaw-brown hkershaw-brown mentioned this issue Aug 17, 2021
Closed
@hkershaw-brown hkershaw-brown mentioned this issue Nov 29, 2021
Open
@hkershaw-brown hkershaw-brown mentioned this issue May 17, 2022
Open
@hkershaw-brown hkershaw-brown added the state_structure notes on refactoring of state_structure_mod label May 24, 2022
@hkershaw-brown
Copy link
Member Author

To run the state structure tests

cd DART/developer_tests/io/work
./quickbuild.sh
./test_state_structure

And you will see

./test_state_structure 
 
 --------------------------------------
 Starting ... at YYYY MM DD HH MM SS = 
                 2022  7 19 16 32 57
 Program test_state_structure
 --------------------------------------
 
  set_nml_output No echo of NML values
 ERROR FROM:
  source : $URL$
  routine: test_state_structure
  message: Has not been tested yet with new naming conventions.

So the goal is to get the tests working again.

@hkershaw-brown hkershaw-brown added the psi possible student issue label Aug 15, 2022
@hkershaw-brown hkershaw-brown removed the psi possible student issue label Aug 25, 2022
@hkershaw-brown
Copy link
Member Author

developer test quickbuild.sh
https://github.com/NCAR/DART/tree/developer_tests

@hkershaw-brown hkershaw-brown mentioned this issue Nov 9, 2022
Open
@hkershaw-brown hkershaw-brown added the IO IO refactoring notes and issues label Nov 9, 2022
@hkershaw-brown hkershaw-brown assigned ann-norcio and unassigned mjs2369 Nov 9, 2023
@hkershaw-brown
Copy link
Member Author

Google doc for creating a spec for the tests:
https://docs.google.com/document/d/17YC0rI0HnL02XMhxmeN2hOBczrbvtSWCkvldV2z9Pys/edit

hkershaw-brown added a commit that referenced this issue Aug 15, 2024
@hkershaw-brown
remove test_state_structure because it does nothing
8ff0473 
see #106
hkershaw-brown added a commit that referenced this issue Aug 15, 2024
@hkershaw-brown
remove test_state_structure because it does nothing
8ffa0db 
see #106
@hkershaw-brown hkershaw-brown added the dead-code code not used or does nothing label Nov 8, 2024
hkershaw-brown added a commit that referenced this issue Nov 8, 2024
@hkershaw-brown
tests: remove non-working and unused tests for state IO
09034cd 
fixes #106 (removes dead code)
@hkershaw-brown hkershaw-brown pinned this issue Dec 2, 2024
@hkershaw-brown hkershaw-brown mentioned this issue Dec 4, 2024
Merged
16 tasks
@hkershaw-brown hkershaw-brown unpinned this issue Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hkershaw-brown hkershaw-brown

Labels
Bug Something isn't working dead-code code not used or does nothing IO IO refactoring notes and issues state_structure notes on refactoring of state_structure_mod Test Improves testing capabilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: remove non-working and unused tests for state IO NCAR/DART
4 participants
@hkershaw-brown @mjs2369 @Benjamin-Gunn @ann-norcio