Reduced the complexity and line length.

NC3-LU · Dec 14, 2021 · d2029ef · d2029ef
1 parent 6472199
commit d2029ef
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/survey/management/commands/import_questions.py b/survey/management/commands/import_questions.py
@@ -128,10 +128,7 @@ def handle(self, *args, **options):
 
     @staticmethod
     def does_question_exists(label: str, questions):
-        for question in questions:
-            if question.label == label:
-               return True
-        return False
+        return label in [question.label for question in questions]
 
     @staticmethod
     def process_answers_dependencies(answers_dependencies: Dict):

diff --git a/survey/migrations/1008_surveyquestion_answers_order_and_more.py b/survey/migrations/1008_surveyquestion_answers_order_and_more.py
@@ -18,7 +18,14 @@ class Migration(migrations.Migration):
         migrations.AlterField(
             model_name='surveyquestion',
             name='qtype',
-            field=models.CharField(choices=[('M', 'Multiple Choice'), ('S', 'Single Choice'), ('SS', 'Single Select Choice'), ('T', 'Free text'), ('MT', 'Multiple Choice + Free Text'), ('ST', 'Single Choice + Free Text')], default='M', max_length=2),
+            field=models.CharField(choices=[
+                ('M', 'Multiple Choice'),
+                ('S', 'Single Choice'),
+                ('SS', 'Single Select Choice'),
+                ('T', 'Free text'),
+                ('MT', 'Multiple Choice + Free Text'),
+                ('ST', 'Single Choice + Free Text')
+            ], default='M', max_length=2),
         ),
         migrations.AlterField(
             model_name='surveyquestionanswer',