Remove legacy OODT dependencies #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nutjob4life
requested changes
Jul 22, 2024
| i.hasNext();) { | ||
| Map.Entry entry = (Map.Entry) i.next(); | ||
| String key = entry.getKey().toString(); | ||
| // for (Iterator i = sourceMet.getHashTable().entrySet().iterator(); |
There was a problem hiding this comment.
When considering commenting-out code, either:
- Include a comment explaining why it's commented out … or … 🤔
- If you can't come up with one, then just delete the code completely 😏
| @@ -1,191 +1,185 @@ | |||
| package gov.nasa.pds.harvest.search.crawler.actions; | |||
There was a problem hiding this comment.
Was this entire file commented-out?
Could the file just be deleted?
| @@ -0,0 +1,80 @@ | |||
| //// Copyright 2006-2017, by the California Institute of Technology. | |||
There was a problem hiding this comment.
This looks like a new file but is entirely commented-out … could this just not be part of the commit?
|
@nutjob4life thanks for the review? making these updates on #80 to avoid potential merge conflicts. |
Refactor search-core dependencies
jordanpadams
added a commit
that referenced
this pull request
Jul 22, 2024
Resolves #78 (comment) Resolves #78 (comment) Resolves #78 (comment)
|
Cleanup completed here: 2295786 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Refactor to remove legacy OODT dependencies.
NOTE: Merge #79 into this branch before merging to main
⚙️ Test Data and/or Report
Still working on branch testing workflow, but with everything deployed locally, I was able to run the smoke tests successfully:
♻️ Related Issues
Resolves #75