Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump openjdk from 17-slim to 18-slim in /docker #586

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Bump openjdk from 17-slim to 18-slim in /docker #586

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
# Normally we'd prefer Alpine Linux, but JDK 11 isn't available with it, so
# we go with a slim Debian. Debian's good too.

FROM openjdk:17-slim
FROM openjdk:18-slim


# API JAR file
Expand Down Expand Up @@ -82,7 +82,7 @@

WORKDIR /usr/local/registry-api-service
EXPOSE ${SERVER_PORT}
CMD java $JAVA_OPT -jar /usr/local/registry-api-service/registry-api-service.jar \

Check warning on line 85 in docker/Dockerfile

View workflow job for this annotation

GitHub Actions / 🪵 Branch Testing (17)

JSON arguments recommended for ENTRYPOINT/CMD to prevent unintended behavior related to OS signals 

JSONArgsRecommended: JSON arguments recommended for CMD to prevent unintended behavior related to OS signals
More info: https://docs.docker.com/go/dockerfile/rule/json-args-recommended/
gov.nasa.pds.api.registry.SpringBootMain --server.port=${SERVER_PORT} ${SPRING_BOOT_APP_ARGS}


Expand All @@ -92,6 +92,6 @@
# `org.label-schema` is deprecated, but no one can figure out whatever
# replaced it, so we'll use it here.

LABEL "org.label-schema.name" = "PDS Registry API"

Check warning on line 95 in docker/Dockerfile

View workflow job for this annotation

GitHub Actions / 🪵 Branch Testing (17)

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
LABEL "org.label-schema.description" = "Planetary Data System's Application Programmer's Interface for the Registry"

Check warning on line 96 in docker/Dockerfile

View workflow job for this annotation

GitHub Actions / 🪵 Branch Testing (17)

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
LABEL "org.label-schema.url" = "https://github.com/NASA-PDS/registry-api"

Check warning on line 97 in docker/Dockerfile

View workflow job for this annotation

GitHub Actions / 🪵 Branch Testing (17)

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
Loading