Handle Accept header with multiple values #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jordanpadams , you noticed that bug yesterday and I cowardly pretended that was not a bug ;) Actually, today I wanted to fix that because I was thinking if the API URL will not work from a browser that will make us have to answer more question and not look too good. So I looked at that, thinking this was more like a configuration issue, but realized there was an actual bug when multiple formats are proposed as supported returned format in the Accept header, e.g. text/html or application/svg, .... This is what web browsers do. |
|
@tloubrieu-jpl I notice this has not yet been deployed to production? Unfortunately, most folks do the same thing I do which is put a URL into a browser, which doesn't work :-/ . |
tloubrieu-jpl
added a commit
that referenced
this pull request
Sep 3, 2024
…h Serverless (#531) * implement RegistrySearchRequestBuilder.applyMultipleProductsDefaults() * switch /products and membership endpoints to use applyMultipleProductsDefaults() * rename RegistrySearchRequestBuilder.onlyLatest() to noSupersededProducts() the semantics of the new name are clearer and cannot lead to confusion about its behaviour * fix terraform deployment on MCP dev * add ssm parameter to share the load balancer domain with other components * rename noSupersededProduct -> excludeSupersededProducts * update application.properties for latest code * make operator, NOT, LIKE, AND, OR antlr tokens case-insensitive * add Query parameter to membership endpoints (#526) * Handle Accept header with multiple values (#529) * properly manage Accept header with multiple options * move MVC function in appropriate class, add unit tests --------- Co-authored-by: thomas loubrieu <thomas.loubrieu@jpl.nasa.gov> * implement PdsProperty * apply propertiesList response schema to '*' content-type * implement /properties endpoint * add warning on /docs end-point which does not work yet --------- Co-authored-by: edunn <alexander.e.dunn@jpl.nasa.gov> Co-authored-by: thomas loubrieu <thomas.loubrieu@jpl.nasa.gov> Co-authored-by: Jordan Padams <33492486+jordanpadams@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
We fix the handling of multiple Accept header as those provided by web browser.
Since the handling of this header value got a bit more complex, we moved the related code to the MVC configuration specifically.
⚙️ Test Data and/or Report
One of the following should be included here:
Use PR in registry repository NASA-PDS/registry#318
Unit tests have also been added.
♻️ Related Issues
Fixes requirement #439