Remove blob #513
Merged
Remove blob #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 12, 2024 14:45
alexdunnjpl
reviewed
Jul 24, 2024
terraform/ecs.tf
Outdated
There was a problem hiding this comment.
Were these changes an intentional part of this PR?
There was a problem hiding this comment.
They are also part of another PR #482 which was not approved/merged. SoI embedded it here.
alexdunnjpl
reviewed
Jul 24, 2024
There was a problem hiding this comment.
Were these changes an intentional part of this PR?
alexdunnjpl
reviewed
Jul 24, 2024
Comment on lines
111
to
117
| log.debug("Excluded fields are " + excluded_fields); | ||
| for (Map.Entry<String, Object> entry : sourceAsMap.entrySet()) { | ||
| try { | ||
| apiProperty = SearchUtil.openPropertyToJsonProperty(entry.getKey()); | ||
| if ((excluded_fields == null) || !excluded_fields.contains(apiProperty)) | ||
| log.debug("see if property " + apiProperty + "should be added"); | ||
| if ((excluded_fields == null) || !excluded_fields.contains(apiProperty)) { | ||
| log.debug("confirmed, the property is being added"); |
There was a problem hiding this comment.
Are these lines intended to remain in the codebase, or were they temporary dev logs?
There was a problem hiding this comment.
Right temporary logs. I can remove them.
alexdunnjpl
approved these changes
Jul 24, 2024
added 2 commits
July 24, 2024 19:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Removes the blob from the application/json and kvp responses.
⚙️ Test Data and/or Report
Test with postman, see PR : NASA-PDS/registry#301
♻️ Related Issues
Fixes #497
Fixes #514