Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch workflows now include not just unit tests but integration tests using Docker Compositions #369

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

nutjob4life
Copy link
Member

πŸ—’οΈ Summary

Merge this to resolve #269 which adds a full integration test to the branch-triggered workflow.

βš™οΈ Test Data and/or Report

You can see a run of this in the sandbox. Yes, the run is "in the red", but that's because integration tests currently have 34 failed assertions. Successful exposition!

♻️ Related Issues

@sonatype-lift
Copy link

sonatype-lift bot commented Aug 9, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

πŸ“– Read about the impacts and timeline

Copy link
Contributor

@alexdunnjpl alexdunnjpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Now we just have to get around to resolving those failing tests πŸ₯²

@alexdunnjpl
Copy link
Contributor

@nutjob4life actually, real-talk, would it be viable to have that as a separate stage? If only so that unit-test regressions don't get ignored because "BIT/BT always fails now".

@nutjob4life
Copy link
Member Author

LGTM!

Now we just have to get around to resolving those failing tests πŸ₯²

Sooo faaast @alexdunnjpl! πŸŽβ–β–‚β–ƒβ–„β–…β–†β–†β–‡β–‡β–ˆβ–ˆπŸ’¨

@nutjob4life nutjob4life merged commit f66814c into main Aug 9, 2023
@nutjob4life nutjob4life deleted the i269 branch August 9, 2023 18:07
@nutjob4life
Copy link
Member Author

@nutjob4life actually, real-talk, would it be viable to have that as a separate stage? If only so that unit-test regressions don't get ignored because "BIT/BT always fails now".

Absolutely, @alexdunnjpl

@alexdunnjpl
Copy link
Contributor

Just saw that comment/link after missing it the first time.

@jordanpadams your thoughts on the above? Should I open a ticket for it?

@jordanpadams
Copy link
Member

@alexdunnjpl See #397 comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add registry/docker compose integration tests to github action on dev branches
3 participants