Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AWS deployment resources for version 1.2.0 #331

Merged
merged 3 commits into from
May 3, 2023
Merged

Update AWS deployment resources for version 1.2.0 #331

merged 3 commits into from
May 3, 2023

Conversation

tloubrieu-jpl
Copy link
Member

@tloubrieu-jpl tloubrieu-jpl commented May 3, 2023 •
edited
Loading

🗒️ Summary

  • The Dockerfile.aws has been updated to use jdk17
  • The application.properties.aws has been updated to match updates of the main application.properties
  • Not In The PR: The cloudfront function used to add headers to the incoming request has been updated and tested.

The deployment has been tested on gamma with the newly generated docker image, see:
https://pds.nasa.gov/api/search-en-gamma/1/

⚙️ Test Data and/or Report

One of the following should be included here:

  • Reference to regression test included in code (preferred wherever reasonable)
  • Attach test data here + outputs of tests

♻️ Related Issues

fixes #330
fixes NASA-PDS/registry#191

alexdunnjpl
alexdunnjpl requested changes May 3, 2023
View reviewed changes
Copy link
Contributor

@alexdunnjpl alexdunnjpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good besides the workflow change

@tloubrieu-jpl tloubrieu-jpl merged commit 5226e54 into main May 3, 2023
@tloubrieu-jpl tloubrieu-jpl deleted the fix_aws_1.2.0 branch May 3, 2023 17:35
@tloubrieu-jpl tloubrieu-jpl mentioned this pull request May 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexdunnjpl alexdunnjpl alexdunnjpl approved these changes

@al-niessner al-niessner Awaiting requested review from al-niessner al-niessner is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tloubrieu-jpl @alexdunnjpl