pds-api 68 : Add hits and took

[al-niessner]

Summary*
Added hits and took to the swagger. Adjusted the logic to fill in these items.

Test Data and/or Report

Using a standard curl, the results now show 'hits' and 'took':

$ curl --header 'Accept: application/json' "http://localhost:8080/bundles/urn:nasa:pds:izenberg_pdart14_meap::1.0/products?limit=1&start=0&fields=ops:Label_File_Info.ops:md5_checksum&only-summary=true"

{"summary":{

  "hits":65, "took":168,

"start":0,"limit":1,"sort":[],"properties":["vid","product_class","ops:Label_File_Info/ops:md5_checksum","ref_lid_instrument_host","ref_lid_investigation","lidvid","ref_lid_target","title","ref_lid_instrument","ops:Label_File_Info/ops:file_ref"]}}

Stating that there are 65 possibilities (hits) and it the processing time was 168 ms (took).

Related Issues

* fixes issues in [pds-api] repo:
    - [68](https://github.com/NASA-PDS/pds-api/issues/68)
    - [87](https://github.com/nasa-pds/pds-api/issues/87)
    - [105](https://github.com/NASA-PDS/pds-api/issues/105)
    - #31 (actually this repo)

[al-niessner]

@jordanpadams @tloubrieu-jpl

None of the checks run because cannot reliably update the api artifact for your automatic scripts to use. Anyway, ready for review as all 4 tickets are complete and tested as shown in the initial block of this pull request.

[tloubrieu-jpl]

@al-niessner I am expecting an update of the swagger definition of the API with the new hits and took attributes. I am not seeing a branch on the swagger-ui or on the pds-qpi-javalib repository for that. The registry-api-service repo does not build without these updates apparently.

Thanks,

Thomas

[tloubrieu-jpl]

@al-niessner I am expecting an update of the swagger definition of the API with the new hits and took attributes. I am not seeing a branch on the swagger-ui or on the pds-qpi-javalib repository for that. The registry-api-service repo does not build without these updates apparently.

Thanks,

Thomas

@al-niessner you can ignore this comment, I found the branch on swagger I did not scroll down the version menu.

[tloubrieu-jpl]

@al-niessner , @jordanpadams, I am wondering what "-1 indicating an excessive amount of resource required to compute it" does mean ? I guess we are sometimes unable to get the number of results matching the request criteria. Is that what it means ?

[al-niessner]

@al-niessner , @jordanpadams, I am wondering what "-1 indicating an excessive amount of resource required to compute it" does mean ? I guess we are sometimes unable to get the number of results matching the request criteria. Is that what it means ?

There could be cases because of nested looping where it may be desirable not to spend the hours (excessive time/resources) computing the total number of hits but rather return in the millisecond of getting the information the user requested.

Currently, we spend the excessive time/resources with a future option being to once again optimize it when the extra delays are better understood. I just left the -1 in the API for the future.

[tloubrieu-jpl]

The keyword parameter should be added back in the code.
The naming of the variable still makes it unclear to me how the code works.

Thanks

[jordanpadams]

@al-niessner would you mind quickly reviewing my changes here (revert keyword removal) and here (fix merge conflicts) so we can merge the PR?

[al-niessner]

@al-niessner would you mind quickly reviewing my changes here (revert keyword removal) and here (fix merge conflicts) so we can merge the PR?

Keyword revert is fine if changes from main support it. Problem I had was that it only appeared in code but not in api maven artifact. If it is in api maven artifact, then it should be reinstated in the code.

The second change should not be returned to service. There is more comprehensive code for lid to lidvid lookups and the fix for returning 404 when lid/lidvid do not exist requires that those lines be removed. Looks like you may have a bad merge somewhere back on the main branch.

[al-niessner]

The if part is no longer desired.

[al-niessner]

@jordanpadams @jimmie

Fixed the fix. Should be good for a merge.