Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tool registry search result count is incorrect #102

Closed
tloubrieu-jpl opened this issue Oct 10, 2024 · 5 comments
Closed

tool registry search result count is incorrect #102

tloubrieu-jpl opened this issue Oct 10, 2024 · 5 comments
Assignees
Labels
B15.1 bug Something isn't working s.medium

Comments

@tloubrieu-jpl
Copy link
Member

tloubrieu-jpl commented Oct 10, 2024

Checked for duplicates

No - I haven't checked

🐛 Describe the bug

  • number of product per page (10) does not match the text Displaying ...
  • the number of result is lower than it was before
  • the radiobutton do not work
Screenshot 2024-11-13 at 5 06 32 PM
@jordanpadams
Copy link
Member

@tloubrieu-jpl who identified this issue? And is anyone working it?

@tloubrieu-jpl
Copy link
Member Author

tloubrieu-jpl commented Oct 11, 2024 via email

@c-suh
Copy link

c-suh commented Oct 11, 2024

For the first issue - the number of results always being 10 despite the counter saying otherwise (e.g., 1-50, 51-65) - the solution is to specify the rows parameter when setting the query for solr. I can provide the exact code and location or make the change myself (to __ branch); lmk which is preferable.

@jordanpadams
Copy link
Member

@c-suh if it is an easy fix, you can go ahead with the PR. Thanks!

@jordanpadams jordanpadams changed the title tool registry does not completely work tool registry search result count is incorrect Nov 14, 2024
@jordanpadams jordanpadams removed their assignment Nov 14, 2024
@github-project-automation github-project-automation bot moved this to Sprint Backlog in B15.1 Nov 14, 2024
@c-suh
Copy link

c-suh commented Nov 14, 2024

The fix had already been pushed to its own branch, so I did the requisite merges, and it is now deployed at https://pds.nasa.gov/tools/tool-registry/.

@c-suh c-suh closed this as completed Nov 14, 2024
@github-project-automation github-project-automation bot moved this from Sprint Backlog to 🏁 Done in B15.1 Nov 14, 2024
@github-project-automation github-project-automation bot moved this from ToDo to 🏁 Done in EN Portfolio Backlog Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B15.1 bug Something isn't working s.medium
Projects
Status: 🏁 Done
Status: 🏁 Done
Development

No branches or pull requests

3 participants