Fix memory leaks with Solr client connections for deprecated Solr #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix memory leaks for solr connection left open. Not sure why this wasn't an issue before. Maybe Tomcat would kill these threads after so long, and since we are getting pummeled with queries, the threads didn't have a chance to die. Either way, closing the solr client connections each time seems to fix it. Fixes #14
jordanpadams
added a commit
that referenced
this pull request
Oct 19, 2023
Fix memory leaks for solr connection left open. Not sure why this wasn't an issue before. Maybe Tomcat would kill these threads after so long, and since we are getting pummeled with queries, the threads didn't have a chance to die. Either way, closing the solr client connections each time seems to fix it. Cherry-picked from `hotfix/2.14.4` branch and `v2.14.4` release Fixes #14 Refs #15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix memory leaks for solr connection left open.
Not sure why this wasn't an issue before. Maybe Tomcat would kill these threads after so long, and since we are getting pummeled with queries, the threads didn't have a chance to die.
Either way, closing the solr client connections each time seems to fix it.
For the implementation, we could have opened it during the constructor, leave it open, and then have a
closeConnectionmethod but my concern there was we would have to add that close call to all the JSPs, and it is really hard to ensure those JSPs will complete execution to the bottom. Would rather have more open connections we know we close, versus leaving it to the client to close it.Testing in production 😨
This thread count stayed stuck at 195 for 15 minutes while we had ~200 queries during that timeframe (196 when it was in the middle of a connection)
Fixes #14