Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SEARCH/ACCESS issue for LIDVID resource references #13

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Fix SEARCH/ACCESS issue for LIDVID resource references #13

merged 3 commits into from
Oct 13, 2023

Conversation

jordanpadams
Copy link
Member

@jordanpadams jordanpadams commented Oct 13, 2023 •
edited
Loading

🗒️ Summary

Update getResourceLinks to support lidvids

  • new getLID method to parse LIDVIDs if they exist
  • clear params when >1 resources

⚙️ Test Data and/or Report

  • Loaded some data into prod1
Screenshot 2023-10-13 at 2 17 17 PM

♻️ Related Issues

Resolves #12

@jordanpadams
Revert Solr URL to Solr deprecated endpoint
ac433e3
@jordanpadams
Update getResourceLinks to support lidvids
1c5509d 
* new getLID method to parse LIDVIDs if they exist
* clear params when >1 resources

Refs #12
@jordanpadams
Prep for v2.14.3 tag
708d232
@jordanpadams jordanpadams changed the title I12 Fix SEARCH/ACCESS issue for LIDVID resource references Oct 13, 2023
@jordanpadams jordanpadams requested a review from a team October 13, 2023 21:27
nutjob4life
nutjob4life approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@nutjob4life nutjob4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Reminder:

One of the following should be included here:

Reference to regression test included in code (preferred wherever reasonable)
Attach test data here + outputs of tests

You can delete this section if it's not applicable 😇

@jordanpadams
Copy link
Member Author

@nutjob4life thanks for the approval and remind. Add the screenshot of the post-fix.

@jordanpadams jordanpadams merged commit 5fb6519 into hotfix/2.14.3 Oct 13, 2023
@jordanpadams jordanpadams deleted the i12 branch October 13, 2023 21:32
@jordanpadams jordanpadams mentioned this pull request Oct 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nutjob4life nutjob4life nutjob4life approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jordanpadams @nutjob4life