Support S2C #49
Merged
Support S2C #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Chuck Daniels <chuck@developmentseed.org> Co-authored-by: Ciaran Sweet <9111975+ciaransweet@users.noreply.github.com>
- Rather than hard-code "S2A" and "S2B" as the platforms to generate search query parameters, expect the PLATFORMS env var to be set as a comma-separated list of platforms, so we can set it to "S2B,S2C" when we're ready to cutover to S2C support. - Update pytest* dependencies to their latest versions - Move unit tests to doctest docstrings for simplicity/clarity
During CDK's builds of Python Lambda Docker images, there were 10s of megabytes of files needlessly being put into the Docker context, primarily from places like the python, mypy, and ruff caches. We can tell the CDK to ignore these assets and greatly speed up build times.
- Eliminate the Platform type alias and simply use `str` as the type - Use latest versions of pytest* deps - Fix code coverage CLI option to pytest to reflect previous code restructuring so coverage report is properly generated
ceholden
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I am changing
Sentinel 2C is replacing 2A, so this adds support for fetching 2C data.
How I did it
I changed the date generator lambda to expect a PLATFORMS environment variable to specify which platforms to generate link fetcher queries for. I added PLATFORMS set to "S2A,S2B" to both the dev and prod GH envs for this repo. When we're ready to cut over to S2C we can change them to "S2C,S2B".
How you can test it
Run the unit tests and integration tests as per the top-level README.md instructions.