Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing bucket write permissions to downloader Lambda and cleanup IntHub references #43

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

ceholden
Copy link
Collaborator

@ceholden ceholden commented Nov 7, 2024

What I am changing

This PR,

  • Fixes a missing PutObject and similar write permissions for the downloader Lambda. This was missing from our stack so I've added it manually in the meantime
  • Removes references to IntHub from documentation and code, replacing it with mentions of "Copernicus Data Space Ecosystem" (CDSE) where relevant

It might be easier to review this PR commit-by-commit because there's relatively few lines of code changed for the actual bugfix versus for cleaning up SciHub/IntHub mentions

How I did it

  • Add reference to the UPLOAD_BUCKET to our stack and add write permission to it for the downloader Lambda
  • grep / delete or reword / repeat mentions of SciHub or IntHub

How you can test it

We can see the bucket permissions have been added via make diff from repo root (this runs cdk diff).

The USE_INTHUB toggle had been removed in previous work and has had no effect, so this change is a no-op other than some clean up.

@ceholden ceholden marked this pull request as ready for review November 7, 2024 19:09
Copy link
Collaborator

@chuckwondo chuckwondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ceholden ceholden merged commit e202d60 into main Nov 7, 2024
3 checks passed
@ceholden ceholden deleted the fix/add-missing-permissions branch November 7, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants