fix: add missing bucket write permissions to downloader Lambda and cleanup IntHub references #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I am changing
This PR,
PutObject
and similar write permissions for the downloader Lambda. This was missing from our stack so I've added it manually in the meantimeIt might be easier to review this PR commit-by-commit because there's relatively few lines of code changed for the actual bugfix versus for cleaning up SciHub/IntHub mentions
How I did it
UPLOAD_BUCKET
to our stack and add write permission to it for the downloader LambdaHow you can test it
We can see the bucket permissions have been added via
make diff
from repo root (this runscdk diff
).The
USE_INTHUB
toggle had been removed in previous work and has had no effect, so this change is a no-op other than some clean up.