Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set identifier to esa-prod for continuity #42

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

ceholden
Copy link
Collaborator

@ceholden ceholden commented Nov 6, 2024

What I am changing

This PR updates the deploy step to point to the same stack that has been running (esa-prod, not prod). This change had happened as part of the switch to the ESA Copernicus services instead of IntHub. These changes weren't propagated back to "infrastructure as code" and the downloader stack wasn't redeployed using the IDENTIFIER=prod target, so this PR seeks to resolve this "drift"

I could see this going the other way (tear down "esa-prod" stack after getting "prod" to work) but having the cdk diff against existing stack seems safer to me than a full cutover without an easy way to compare the stacks. Additionally there are a number of secrets that "esa-prod" has already configured.

How I did it

Find/replace

How you can test it

Integration tests should still work and we'll have a fairly small cdk diff that mostly includes,

  • Definition of Lambda assets is shorter in CDK v2 for the S3Key (no need to lookup refs from stack). Generally there's a few .Ref changes to be .Fn::Sub, which in other words means that the metadata is more directly specified
  • Python 3.8 ~> 3.11 runtime
  • A few StepFunction changes,
    • CDK v2 includes an extra AWS as defaults that retry will run on
    • The Principal in AssumeRolePolicyDocument for step function is now just states.amazonaws.com

Copy link
Collaborator

@chuckwondo chuckwondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing this was rather arduous. Perhaps in the future you can break up such large changes into smaller pieces :-)

@sharkinsspatial
Copy link
Collaborator

@ceholden This approach is good with me. For historical context we needed to maintain both deployments in parallel previously while we were diagnosing ongoing problems with the CDE publication streams.

@ceholden ceholden merged commit 4553661 into main Nov 6, 2024
3 checks passed
@ceholden ceholden deleted the fix/set-identifier-esa-prod branch November 6, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants