fix: Set identifier to esa-prod for continuity #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I am changing
This PR updates the deploy step to point to the same stack that has been running (
esa-prod
, notprod
). This change had happened as part of the switch to the ESA Copernicus services instead of IntHub. These changes weren't propagated back to "infrastructure as code" and the downloader stack wasn't redeployed using theIDENTIFIER=prod
target, so this PR seeks to resolve this "drift"I could see this going the other way (tear down "esa-prod" stack after getting "prod" to work) but having the
cdk diff
against existing stack seems safer to me than a full cutover without an easy way to compare the stacks. Additionally there are a number of secrets that "esa-prod" has already configured.How I did it
Find/replace
How you can test it
Integration tests should still work and we'll have a fairly small
cdk diff
that mostly includes,S3Key
(no need to lookup refs from stack). Generally there's a few.Ref
changes to be.Fn::Sub
, which in other words means that the metadata is more directly specifiedPrincipal
in AssumeRolePolicyDocument for step function is now juststates.amazonaws.com