Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: finalize support for Visible Human DICOM color images in Slicer #875

Closed
pieper opened this issue Jan 8, 2024 · 7 comments
Closed

Proposal: finalize support for Visible Human DICOM color images in Slicer #875

pieper opened this issue Jan 8, 2024 · 7 comments
Assignees
@RafaelPalomar @drouin-simon @piiq @sjh26 @tkapur
Labels
event:PW40_2024_GranCanaria proposal

Comments

@pieper
Copy link
Contributor

pieper commented Jan 8, 2024

Project Description

3D Slicer reads the VHP pixel data, but the geometry is incorrect. I traced this to the way GDCM treats SC data. Fixes have been proposed but need to be finalized.

InsightSoftwareConsortium/ITK#4109

InsightSoftwareConsortium/ITK#4108

InsightSoftwareConsortium/ITK#4110

@jcfr - can you and I set aside a bit of time to work through this? @fedorov asked me to try to finish this effort this month. It shouldn't be much work.
@fedorov
Copy link
Member

fedorov commented Jan 17, 2024

@jcfr will you have time to help with this?

Steve, are you waiting to hear from JC before creating the project page?

It would be nice for IDC to have this issue finally resolved.

@pieper
Copy link
Contributor Author

pieper commented Jan 17, 2024

Yes, I was thinking I would hear from Jc and that would ping me to make a page, but since I can sort this out on my own so if he won't have time maybe this isn't a good project week project after all. It's just a matter of me allocating the time and energy.

@sjh26
Copy link
Contributor

sjh26 commented Jan 23, 2024

@pieper

If you are still intending to do this project, please create a project issue.

@pieper
Copy link
Contributor Author

pieper commented Jan 24, 2024

There will be a lot of other things to work on during project week so we'll kick this one down the road (again).

@pieper pieper closed this as not planned Won't fix, can't repro, duplicate, stale Jan 24, 2024
@jcfr
Copy link
Contributor

jcfr commented Jan 24, 2024

On a reduced schedule until the end of the week, I am catching up on message et al.

If that still makes sense, happy to spend some time on this.

@pieper
Copy link
Contributor Author

pieper commented Jan 24, 2024

Thanks Jc. Maybe we can just chat about this when we are together.

@fedorov
Copy link
Member

fedorov commented Jan 24, 2024

Thank you @jcfr - it would be good to resolve this, it's been pending for quite some time, and I am afraid if it is not addressed this PW it is not going to have any attention until the next one.

thewtex added a commit to thewtex/ITK that referenced this issue Mar 18, 2024
@thewtex
ENH: Enable SecondaryCaptureImagePlaneModel in GDCM
1e6b14e 
This enables support for reading image orientation patient and image
position patient from DICOM secondary capture images.

This addresses needs such as reading Visibla Human DICOM color images in
3D Slicer:

  NA-MIC/ProjectWeek#875

and reading highdicom derived secondary capture DICOM in ITK-Snap:

  ImagingDataCommons/highdicom#247

The required patch has not yet been merged upstream:

  malaterre/GDCM#167

but is available in ITK-vendored GDCM, so condition enablement on
NOT ITK_USE_SYSTEM_GDCM and provide a warning and pointer on where to
find the patches for package managers and other redistributors that also
the support.
thewtex added a commit to thewtex/ITK that referenced this issue Mar 25, 2024
@thewtex
ENH: Enable SecondaryCaptureImagePlaneModel in GDCM
f545dd8 
This enables support for reading image orientation patient and image
position patient from DICOM secondary capture images.

This addresses needs such as reading Visible Human DICOM color images in
3D Slicer:

  NA-MIC/ProjectWeek#875

and reading highdicom derived secondary capture DICOM in ITK-Snap:

  ImagingDataCommons/highdicom#247

Update the RGB tests' baseline that were using a .png baseline because they now
output spatial metadata.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RafaelPalomar RafaelPalomar

@drouin-simon drouin-simon

@piiq piiq

@sjh26 sjh26

@tkapur tkapur

Labels
event:PW40_2024_GranCanaria proposal
Milestone
No milestone
Development

No branches or pull requests
8 participants
@pieper @jcfr @fedorov @RafaelPalomar @drouin-simon @piiq @sjh26 @tkapur