fix pr meta script

N-Coder · Mar 27, 2024 · 785eacd · 785eacd
1 parent cdb31fa
commit 785eacd
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/.github/workflows/sonar.yml b/.github/workflows/sonar.yml
@@ -13,6 +13,7 @@ jobs:
     steps:
       - name: Install sonar-scanner
         uses: SonarSource/sonarcloud-github-c-cpp@v2
+        cache-binaries: false
       - name: Dump GitHub context
         env:
           GITHUB_CONTEXT: ${{ toJson(github) }}
@@ -46,16 +47,16 @@ jobs:
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           script: |
-            var fs = require('fs');
-            var pr_number = Number(fs.readFileSync('static-analysis/PR-NUMBER'));
-            var pr_meta = await github.pulls.get({
-              ${{ github.event.workflow_run.repository.owner.login }},
-              ${{ github.event.workflow_run.repository.name }},
-              pr_number,
+            const fs = require('fs');
+            const pr_number = Number(fs.readFileSync('static-analysis/PR-NUMBER'));
+            const { data: pr_meta } = await github.pulls.get({
+              owner: '${{ github.event.workflow_run.repository.owner.login }}',
+              repo: '${{ github.event.workflow_run.repository.name }}',
+              pull_number: pr_number,
             });
             console.log(pr_meta);
-            if (github.event.workflow_run.head_commit.id != pr_meta.head.sha) {
-              core.setFailed('Triggering workflow commit sha doesn't match claimed PR head commit sha!');
+            if ('${{ github.event.workflow_run.head_commit.id }}' != pr_meta.head.sha) {
+              core.setFailed('Triggering workflow commit sha does not match claimed PR head commit sha!');
             }
             return pr_meta;
       - name: Dump GitHub context 2