Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Require sabberworm/php-css-parser:^8.4.0 #1134

Merged
merged 1 commit into from
Dec 13, 2021
Merged

[TASK] Require sabberworm/php-css-parser:^8.4.0 #1134

merged 1 commit into from
Dec 13, 2021

Conversation

oliverklee
Copy link
Contributor

@oliverklee oliverklee commented Dec 13, 2021 •
edited
Loading

Fixes #1127

Also fixes parts of #1130 by removing some redundant type annotations,
and log the other Psalm warnings into the Psalm baseline so we can
fix them later.

@oliverklee oliverklee added this to the 7.0.0 milestone Dec 13, 2021
@oliverklee oliverklee requested a review from JakeQZ December 13, 2021 17:53
@oliverklee oliverklee self-assigned this Dec 13, 2021
@oliverklee
[TASK] Require sabberworm/php-css-parser:^8.4.0
ba145fc 
Fixes #1127

Also fixes parts of #1130 by removing some redundant type annotations,
and log the other Psalm warnings into the Psalm baseline so we can
fix them later.
@oliverklee oliverklee force-pushed the task/css-parser-upgrade branch from bcecd1e to ba145fc Compare December 13, 2021 17:53
JakeQZ
JakeQZ approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thorough.

@JakeQZ
Copy link
Contributor

JakeQZ commented Dec 13, 2021

Not sure how to merge while there are still build errors from Symfony.

@oliverklee
Copy link
Contributor Author

oliverklee commented Dec 13, 2021 •
edited
Loading

Not sure how to merge while there are still build errors from Symfony.

I have administrator superpowers in this project and can also move merge with a red build. :-)

@oliverklee oliverklee merged commit 7c6bd46 into main Dec 13, 2021
@oliverklee oliverklee deleted the task/css-parser-upgrade branch December 13, 2021 22:23
@JakeQZ JakeQZ mentioned this pull request Dec 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

Require PHP CSS Parser ^8.4.0
2 participants
@oliverklee @JakeQZ