Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle malformed RGB HEX values #387

Closed
wants to merge 5 commits into from
Closed

Handle malformed RGB HEX values #387

wants to merge 5 commits into from

Conversation

raxbg
Copy link
Contributor

@raxbg raxbg commented Sep 17, 2022

No description provided.

@oliverklee oliverklee deleted the branch MyIntervals:main February 7, 2024 11:36
@oliverklee oliverklee closed this Feb 7, 2024
@oliverklee oliverklee reopened this Feb 7, 2024
@oliverklee oliverklee changed the base branch from master to main February 7, 2024 22:34
JakeQZ
JakeQZ reviewed Feb 28, 2024
View reviewed changes
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @raxbg,

This has been fixed by #485 with an almost identacal code change. Additional tests were added with #359.

I'm going through the open PRs starting with those more recent, so got to #485 before this. It's reassuring to see that the change you proposed matches the change agreed upon there.

I think this can be closed as a duplicate, unless you think including the additional test here would add extra value - ?

Thanks.

@JakeQZ JakeQZ added bug rebase needed testing PRs/issues adding additional tests only, or primarily testing-focused duplicate labels Feb 28, 2024
@raxbg
Copy link
Contributor Author

raxbg commented Jul 10, 2024

Hi @raxbg,

This has been fixed by #485 with an almost identacal code change. Additional tests were added with #359.

I'm going through the open PRs starting with those more recent, so got to #485 before this. It's reassuring to see that the change you proposed matches the change agreed upon there.

I think this can be closed as a duplicate, unless you think including the additional test here would add extra value - ?

Thanks.

Awesome! Closing this one.

@raxbg raxbg closed this Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ left review comments

Assignees
No one assigned
Labels
bug duplicate rebase needed testing PRs/issues adding additional tests only, or primarily testing-focused
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@raxbg @JakeQZ @oliverklee