Main Tests & Analysis

Release v0.8.0 #54

Sign in to view logs

Triggered via pull request June 10, 2024 11:54

synchronize #247

release/v0.8.0

Status Success

Total duration 4m 26s

Artifacts –

branch_main_ci.yml

on: pull_request

Matrix: Tests / Code Tests

Code Analysis / Code coverage

Annotations

35 warnings

Tests / Code Tests (core)

Running this action via 'uses: EnricoMi/publish-unit-test-result-action/composite@v2 is deprecated! For details, see: https://github.com/EnricoMi/publish-unit-test-result-action/tree/v2#running-as-a-composite-action

Tests / Code Tests (core)

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/setup-dotnet@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Tests / Code Tests (core)

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Tests / Code Tests (core): src/api/common/FinancialHub.Common/Results/Errors/ServiceError.cs#L7

#warning: 'it can be changed to an enum or use a different value from https codes'

Tests / Code Tests (core): src/api/core/FinancialHub.Core.Application/Services/TransactionBalanceService.cs#L124

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.

Tests / Code Tests (core): src/api/core/FinancialHub.Core.Infra.Data/Repositories/TransactionsRepository.cs#L13

#warning: 'This is not a good practice, remove this later'

Tests / Code Tests (core): tests/core/FinancialHub.Core.Application.Tests/Services/TransactionBalance/BaseTransactionBalanceTests.cs#L22

'TransactionBalanceService' is obsolete: 'This Service will be removed and the logic will be moved to Balance and Transaction models'

Tests / Code Tests (core): tests/core/FinancialHub.Core.Application.Tests/Services/TransactionBalance/TransactionBalanceTests.updateamount.cs#L42

'IBalancesService.UpdateAmountAsync(Guid, decimal)' is obsolete: 'This logic will be moved to BalanceModel'

Tests / Code Tests (core): tests/core/FinancialHub.Core.Application.Tests/Services/TransactionBalance/TransactionBalanceTests.updateamount.cs#L264

'IBalancesService.UpdateAmountAsync(Guid, decimal)' is obsolete: 'This logic will be moved to BalanceModel'

Tests / Code Tests (core): tests/core/FinancialHub.Core.Application.Tests/Services/TransactionBalance/TransactionBalanceTests.updateamount.cs#L265

'IBalancesService.UpdateAmountAsync(Guid, decimal)' is obsolete: 'This logic will be moved to BalanceModel'

Tests / Code Tests (core): tests/core/FinancialHub.Core.Application.Tests/Services/TransactionBalance/TransactionBalanceTests.updateamount.cs#L269

'IBalancesService.UpdateAmountAsync(Guid, decimal)' is obsolete: 'This logic will be moved to BalanceModel'

Tests / Code Tests (core): tests/core/FinancialHub.Core.Application.Tests/Services/TransactionBalance/TransactionBalanceTests.updateamount.cs#L270

'IBalancesService.UpdateAmountAsync(Guid, decimal)' is obsolete: 'This logic will be moved to BalanceModel'

Tests / Code Tests (core): tests/core/FinancialHub.Core.Application.Tests/Services/TransactionBalance/TransactionBalanceTests.updateamount.cs#L61

'IBalancesService.UpdateAmountAsync(Guid, decimal)' is obsolete: 'This logic will be moved to BalanceModel'

Code Analysis / Code coverage

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/setup-dotnet@v2, actions/setup-java@v3, actions/cache@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Code Analysis / Code coverage

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Code Analysis / Code coverage: src/api/common/FinancialHub.Common/Results/Errors/ServiceError.cs#L7

#warning: 'it can be changed to an enum or use a different value from https codes'

Code Analysis / Code coverage: src/api/common/FinancialHub.Common/Results/Errors/ServiceError.cs#L11

Change the visibility of this constructor to 'protected'.

Code Analysis / Code coverage: src/api/core/FinancialHub.Core.Domain/Queries/TransactionQuery.cs#L20

Complete the task associated to this 'TODO' comment.

Code Analysis / Code coverage: src/api/core/FinancialHub.Core.Domain/DTOS/Balances/BalanceAccountDto.cs#L5

Remove the unused private setter 'set_Id'.

Code Analysis / Code coverage: src/api/core/FinancialHub.Core.Domain/DTOS/Balances/BalanceAccountDto.cs#L6

Remove the unused private setter 'set_Name'.

Code Analysis / Code coverage: src/api/core/FinancialHub.Core.Domain/DTOS/Balances/BalanceAccountDto.cs#L7

Remove the unused private setter 'set_Description'.

Code Analysis / Code coverage: src/api/core/FinancialHub.Core.Domain/DTOS/Balances/BalanceAccountDto.cs#L8

Remove the unused private setter 'set_IsActive'.

Code Analysis / Code coverage: src/api/core/FinancialHub.Core.Domain/Interfaces/Caching/ITransactionsCache.cs#L6

Do not forget to remove this deprecated code someday.

Code Analysis / Code coverage: src/api/core/FinancialHub.Core.Domain/Models/TransactionModel.cs#L8

Remove the unused private setter 'set_Description'.

Code Analysis / Code coverage: src/api/core/FinancialHub.Core.Domain/Models/TransactionModel.cs#L9

Remove the unused private setter 'set_Amount'.

Code Analysis / Code coverage: src/api/common/FinancialHub.Common/Results/Errors/ServiceError.cs#L7

#warning: 'it can be changed to an enum or use a different value from https codes'

Code Analysis / Code coverage: src/api/common/FinancialHub.Common/Results/Errors/ServiceError.cs#L11

Change the visibility of this constructor to 'protected'.

Code Analysis / Code coverage: src/api/core/FinancialHub.Core.Domain/Queries/TransactionQuery.cs#L20

Complete the task associated to this 'TODO' comment.

Code Analysis / Code coverage: src/api/core/FinancialHub.Core.Domain/DTOS/Balances/BalanceAccountDto.cs#L5

Remove the unused private setter 'set_Id'.

Code Analysis / Code coverage: src/api/core/FinancialHub.Core.Domain/DTOS/Balances/BalanceAccountDto.cs#L6

Remove the unused private setter 'set_Name'.

Code Analysis / Code coverage: src/api/core/FinancialHub.Core.Domain/DTOS/Balances/BalanceAccountDto.cs#L7

Remove the unused private setter 'set_Description'.

Code Analysis / Code coverage: src/api/core/FinancialHub.Core.Domain/DTOS/Balances/BalanceAccountDto.cs#L8

Remove the unused private setter 'set_IsActive'.

Code Analysis / Code coverage: src/api/core/FinancialHub.Core.Domain/Interfaces/Caching/ITransactionsCache.cs#L6

Do not forget to remove this deprecated code someday.

Code Analysis / Code coverage: src/api/core/FinancialHub.Core.Domain/Models/TransactionModel.cs#L8

Remove the unused private setter 'set_Description'.

Code Analysis / Code coverage: src/api/core/FinancialHub.Core.Domain/Models/TransactionModel.cs#L9

Remove the unused private setter 'set_Amount'.