Moves validators to Application layer #137
branch_release_ci.yml
on: pull_request
Matrix: Tests / Code Tests
Code Analysis
/
Code coverage
Annotations
3 errors and 12 warnings
|
Tests / Code Tests (core):
tests/core/FinancialHub.Core.Application.Tests/Services/Accounts/AccountsServiceTests.cs#L36
There is no argument given that corresponds to the required formal parameter 'errorMessageProvider' of 'AccountsService.AccountsService(IAccountsProvider, IAccountValidator, IMapper, IErrorMessageProvider)'
|
|
Tests / Code Tests (core):
tests/core/FinancialHub.Core.Application.Tests/Services/Accounts/AccountsServiceTests.cs#L36
There is no argument given that corresponds to the required formal parameter 'errorMessageProvider' of 'AccountsService.AccountsService(IAccountsProvider, IAccountValidator, IMapper, IErrorMessageProvider)'
|
|
Tests / Code Tests (core)
Process completed with exit code 1.
|
|
Tests / Code Tests (core)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/setup-dotnet@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Tests / Code Tests (core)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Tests / Code Tests (core):
src/api/common/FinancialHub.Common/Results/Errors/ServiceError.cs#L7
#warning: 'it can be changed to an enum or use a different value from https codes'
|
|
Tests / Code Tests (core):
src/api/core/FinancialHub.Core.Infra.Data/Repositories/TransactionsRepository.cs#L14
#warning: 'This is not a good practice, remove this later'
|
|
Tests / Code Tests (core):
src/api/core/FinancialHub.Core.Application/Services/TransactionBalanceService.cs#L124
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
Tests / Code Tests (core):
tests/core/FinancialHub.Core.Application.Tests/Services/TransactionBalance/BaseTransactionBalanceTests.cs#L22
'TransactionBalanceService' is obsolete: 'This Service will be removed and the logic will be moved to Balance and Transaction models'
|
|
Tests / Code Tests (core):
tests/core/FinancialHub.Core.Application.Tests/Services/TransactionBalance/TransactionBalanceTests.updateamount.cs#L42
'IBalancesService.UpdateAmountAsync(Guid, decimal)' is obsolete: 'This logic will be moved to BalanceModel'
|
|
Tests / Code Tests (core):
tests/core/FinancialHub.Core.Application.Tests/Services/TransactionBalance/TransactionBalanceTests.updateamount.cs#L61
'IBalancesService.UpdateAmountAsync(Guid, decimal)' is obsolete: 'This logic will be moved to BalanceModel'
|
|
Tests / Code Tests (core):
tests/core/FinancialHub.Core.Application.Tests/Services/TransactionBalance/TransactionBalanceTests.updateamount.cs#L264
'IBalancesService.UpdateAmountAsync(Guid, decimal)' is obsolete: 'This logic will be moved to BalanceModel'
|
|
Tests / Code Tests (core):
tests/core/FinancialHub.Core.Application.Tests/Services/TransactionBalance/TransactionBalanceTests.updateamount.cs#L265
'IBalancesService.UpdateAmountAsync(Guid, decimal)' is obsolete: 'This logic will be moved to BalanceModel'
|
|
Tests / Code Tests (core):
tests/core/FinancialHub.Core.Application.Tests/Services/TransactionBalance/TransactionBalanceTests.updateamount.cs#L269
'IBalancesService.UpdateAmountAsync(Guid, decimal)' is obsolete: 'This logic will be moved to BalanceModel'
|
|
Tests / Code Tests (core):
tests/core/FinancialHub.Core.Application.Tests/Services/TransactionBalance/TransactionBalanceTests.updateamount.cs#L270
'IBalancesService.UpdateAmountAsync(Guid, decimal)' is obsolete: 'This logic will be moved to BalanceModel'
|