Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix presentation hint for non-forms views in forms presenter #3522

Merged
merged 1 commit into from
Sep 4, 2019
Merged

Fix presentation hint for non-forms views in forms presenter #3522

merged 1 commit into from
Sep 4, 2019

Conversation

orzech85
Copy link
Contributor

@orzech85 orzech85 commented Sep 4, 2019

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

fix

⤵️ What is the current behavior?

App crash on close presentation hint if present non-forms view and forms NavigationPage is missing (forms views was not already shown)

🆕 What is the new behavior (if this is a feature change)?

You can close native view with forms presenter

💥 Does this PR introduce a breaking change?

no

🐛 Recommendations for testing

📝 Links to relevant issues/docs

🤔 Checklist before submitting

@orzech85 orzech85 requested a review from a team September 4, 2019 08:48
@martijn00 martijn00 merged commit 9b29125 into MvvmCross:develop Sep 4, 2019
@martijn00 martijn00 added this to the 6.4.0 milestone Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martijn00 martijn00 martijn00 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
6.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@orzech85 @martijn00