Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xml attribute to optimize importing of classes on Forms #3331

Merged
merged 4 commits into from
Apr 16, 2019

Conversation

martijn00
Copy link
Contributor

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Feature

⤵️ What is the current behavior?

🆕 What is the new behavior (if this is a feature change)?

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

📝 Links to relevant issues/docs

🤔 Checklist before submitting

@martijn00 martijn00 added this to the 6.2.4 milestone Mar 21, 2019
MvvmCross.Forms/AssemblyInfo.cs Outdated Show resolved Hide resolved
MvvmCross.Forms/MvxFormsLog.cs Outdated Show resolved Hide resolved
@Cheesebaron
Copy link
Member

Hmm the build doesn't like this:

AssemblyInfo.cs(7,12): error CS0246: The type or namespace name 'AssemblyVersionAttribute' could not be found (are you missing a using directive or an assembly reference?) [C:\projects\mvvmcross\MvvmCross.Forms\MvvmCross.Forms.csproj]
AssemblyInfo.cs(7,12): error CS0246: The type or namespace name 'AssemblyVersion' could not be found (are you missing a using directive or an assembly reference?) [C:\projects\mvvmcross\MvvmCross.Forms\MvvmCross.Forms.csproj]
AssemblyInfo.cs(8,12): error CS0246: The type or namespace name 'AssemblyFileVersionAttribute' could not be found (are you missing a using directive or an assembly reference?) [C:\projects\mvvmcross\MvvmCross.Forms\MvvmCross.Forms.csproj]
AssemblyInfo.cs(8,12): error CS0246: The type or namespace name 'AssemblyFileVersion' could not be found (are you missing a using directive or an assembly reference?) [C:\projects\mvvmcross\MvvmCross.Forms\MvvmCross.Forms.csproj]
AssemblyInfo.cs(9,12): error CS0246: The type or namespace name 'AssemblyInformationalVersionAttribute' could not be found (are you missing a using directive or an assembly reference?) [C:\projects\mvvmcross\MvvmCross.Forms\MvvmCross.Forms.csproj]
AssemblyInfo.cs(9,12): error CS0246: The type or namespace name 'AssemblyInformationalVersion' could not be found (are you missing a using directive or an assembly reference?) [C:\projects\mvvmcross\MvvmCross.Forms\MvvmCross.Forms.csproj]

@Cheesebaron Cheesebaron merged commit c139ad2 into MvvmCross:develop Apr 16, 2019
@martijn00 martijn00 modified the milestones: 6.2.4, 6.3.0 May 13, 2019
@martijn00 martijn00 deleted the xml-attribute branch May 20, 2019 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants