Typed hint on AppStart and documentation #2901
Conversation
MvvmCross/ViewModels/MvxAppStart.cs
Outdated
| MvxLog.Instance.Trace("Hint ignored in default MvxAppStart"); | ||
| } | ||
| //There is no way to pass the hint back | ||
| var typedHint = typedApplication.Startup(parameter); |
There was a problem hiding this comment.
What's the point of doing this since we do nothing with the result? Should it not be above the base call and pass the hint to the base.ApplicationStartup instead?
| @@ -12,8 +12,13 @@ public interface IMvxApplication : IMvxViewModelLocatorCollection | |||
|
|
|||
| void Initialize(); | |||
|
|
|||
| void Startup(object hint); | |||
| object Startup(object hint); | |||
There was a problem hiding this comment.
@martijn00 I'm not sure why we're keeping the object parameter and return type since this can be done by using MvxApplication with THint set to object
There was a problem hiding this comment.
I just wanted to keep this to not break to many things. But it doesn't make a lot of sense. Developers could even just put object as type on the typed Startup.
MvvmCross/ViewModels/MvxAppStart.cs
Outdated
| { | ||
| MvxLog.Instance.Trace("Hint ignored in default MvxAppStart"); | ||
| //There is no way to pass the hint back | ||
| return typedApplication.Startup(parameter); |
There was a problem hiding this comment.
Given this issue, perhaps we should consider passing around a new type, IStartupHint (and associated IStartupHint) that has a property Hint. Rather than passing back an updated hint, the Hint within the IStartupHint object could be updated.
There was a problem hiding this comment.
This was a leftover comment, not an issue anymore since breaking the interface method.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Adds possibility to use a typed hint at appstart.
🆕 What is the new behavior (if this is a feature change)?
💥 Does this PR introduce a breaking change?
Yes, but tried to keep it minimal.
🐛 Recommendations for testing
📝 Links to relevant issues/docs
Fixes #2854
Fixes #2900
🤔 Checklist before submitting