Star wars sample update to v.6.2.0 #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Closed
5 tasks
nmilcoff
suggested changes
Sep 14, 2018
| // workaround which should be removed when https://github.com/MvvmCross/MvvmCross/pull/2972 is released | ||
| var presenter = base.CreateFormsPagePresenter(viewPresenter); | ||
| Mvx.RegisterSingleton<IMvxFormsPagePresenter>(presenter); | ||
| var presenter = new MvxFormsPagePresenter(viewPresenter); |
There was a problem hiding this comment.
Please remove these lines if the workaround isn't necessary anymore.
nmilcoff
approved these changes
Sep 14, 2018
PoLaKoSz
pushed a commit
to PoLaKoSz/MvvmCross-Samples
that referenced
this pull request
May 14, 2019
* Update MvvmCross and Plugins from 6.1.2 to 6.2.0. * Fix StarWarsSample.Forms.Android issue: app stuck on SplashScreen after update to v6.2.0. * Removed unnecessary method from StarWarsSample.Forms.Android Setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update MvvmCross and Plugins from 6.1.2 to 6.2.0.
Fix StarWarsSample.Forms.Android issue: app stuck on SplashScreen after update to v6.2.0. #3104