Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrow heads freaking out occasionally #8

Closed
AntonOresten opened this issue Nov 15, 2023 · 1 comment
Closed

Arrow heads freaking out occasionally #8

AntonOresten opened this issue Nov 15, 2023 · 1 comment

Comments

@AntonOresten
Copy link
Member

AntonOresten commented Nov 15, 2023

Computing tangents/normals/binormals of the arrow surface is currently a little bit of a shitshow, which leads to issues like the one below.

image

I suspect it has to do with the spline (created from oxygen atoms) extending beyond the endpoint.

AntonOresten added a commit that referenced this issue Nov 27, 2023
@AntonOresten
Copy link
Member Author

AntonOresten commented Nov 27, 2023

This issue is getting fixed in v0.2.0 by removing the next to last control point (oxygen atom) of the two splines that form the surface and normals of a strand.

I also made it so that the angle between the arrow body and head is always 90 degrees -- it could look kinda funky when the spline quality was low.

This:
image

turned into this: (no wonky tips)
image

which in turn turned into this: (perpendicular edges)
image

As a result, the colors are also much more consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant