Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API functions for hostinfo, instanceinfo and serverinfo #22

Merged

Conversation

Sebbo94BY
Copy link
Contributor

Adds various new read-only API functions:

  • hostinfo
  • instanceinfo
  • serverinfo

@Murgeye
Copy link
Owner

Murgeye commented Nov 30, 2022

Hi,
thanks for adding this.

Note that I will not update the PIP version for this for now, since you can already call these functions the same way using the default wrapper. But it's always nice to have more explicitly implemented commands.

@Murgeye Murgeye merged commit c6b0f97 into Murgeye:master Nov 30, 2022
@Sebbo94BY Sebbo94BY deleted the Add-API-functions-for-various-info-commands branch November 30, 2022 10:37
@Sebbo94BY
Copy link
Contributor Author

You're welcome!

Ok, but why don't you update the pip version? Are you planning a new release in the future - with more changes? Or which background has this decission?

I mean, for me it's currently fine (I think) as it's implemented as Git submodule in your bot: https://github.com/Murgeye/teamspeak3-python-bot/blob/main/.gitmodules

btw: Really awesome work with the bot! I really like the implementation and how it is working. Especially with the modules/plugin logic, that everyone can extend its features. ❤️

@Murgeye
Copy link
Owner

Murgeye commented Nov 30, 2022

Hey, thanks for the praise 😅

To be honest I am just lazy and have to remember how to push new versions to pip each time. I should probably do it anyway to keep it in sync, even though this commit does not change anything in the usage of the API (as I said you could always call unimplemented commands anyway, you just have no python documentation for them).

I will probably do it in a few days if I find the time.

Thanks again!

@Sebbo94BY
Copy link
Contributor Author

Ah, ok. Haha :D

Yeah, maybe it's possible to automate publishing new pip versions using e.g. Git workflows. Not sure. I've never published a pip package. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants