fix(ci): fix tests using old nvim api #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`vim.api.nvim_win_get_config` used to return a dict of numbers to represent a vim float number for `row` and `col` fields. This behavior was fixed in neovim/neovim#27284 as a **breaking change** to the old API without any notice. Now user can refer to the value of `config.row` without indexing like `config.row[vim.val_idx]`.
|
Haha, devs are soo bad at writing docs lol.
This is the only mention in the docs referring to this breaking change. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #333 +/- ##
=======================================
Coverage 99.04% 99.04%
=======================================
Files 20 20
Lines 2725 2725
=======================================
Hits 2699 2699
Misses 26 26 ☔ View full report in Codecov by Sentry. |
MunifTanjim
approved these changes
Feb 15, 2024
|
Thanks for looking into it 🙌🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vim.api.nvim_win_get_configused to return a dict of numbers to represent a vim float number forrowandcolfields. This behavior was fixed in neovim/neovim#27284 as a breaking change to the old API without any notice. Now user can refer to the value ofconfig.rowwithout indexing likeconfig.row[vim.val_idx].This is the reason why tests are failing in #332.