Build Process Cleanup #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some were fixed by setting Nullable to disabled where expected. Also disabled Security Audit warning globally as there is no way to disable them in specific project where such dependencies cannot be updated. (if anyone know a way, please create a PR)
Removed duplicate .Lib & .Installer, Additionally embedding pdbs globally.
For some reasons, Newtonsoft.Json is going SCHIZO & is trying to load the 0.6.x dll when the daemon plugin relies on 0.5.x & the object returned depends on 0.5.x .Plugin. Was also happening in 0.6.x.
This was referenced Oct 8, 2024
|
Final pass will be done tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified the build process by separating the lib's csproj for 0.5.x & 0.6.x into their own folder, where the later, include every .cs file from the former.
Fixed many warnings by disabling nullable globally & only enabling it where necessary,
Fixed a warning when building in 0.6.x, a return statement was unreachable (it was intended to be used inside the .NET 5 conditional).
I had a netstandard refactor branch ongoing, but it's probably going to go down the drain as this PR uses the much simpler fix of
just working around the Nuget multi-targeting issue by using a separate project folder for restore.EDIT: I'm just using a target to alter the
PackageIdnow, providing the intended behavior if the NuGet bug didn't exist.It would had probably been better to continue with that branch as a lot of the backend was made simpler through abstraction, however, such abstraction came at a cost, being a large overhead, especially when constantly converting version specific objects to a common one (E.g: Touch Reports, Touch Points, ...)
This could potentially be fixed by using a stub report that doesn't get re-instantiated every reports, but it will still come at a cost as for the extra iterations required to copy each points.