Using selected mode (dark, light) by default when userChoice is enabled #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I propose a change in the logic that picks the color mode (light, dark) to use. It's simpler, and I think achieves the same behaviour as before, with an improvement for a specific case.
The following rules from the docs will still work:
But also, this will happen now:
Which I believe works better than the current behavior (forcing light mode in that case until the user makes a choice).
This would close #28.