Ports multiple storage visual/QOL PRs of mine #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## About The Pull Request This PR rewrites some storage UI code to make it compose itself from multiple elements (corners and row connectors) and allow it to be affected by player's preferred UI theme. Also resprites it and adds variations for all themes. Midnight (Default UI theme, the example doesn't show it very well but the cells are rather transparent)  Some examples of other themes. (Shows transparency much better)   ## Why It's Good For The Game Storage UI is ancient and doesn't look very good, nor fit the modern UI in general. ## Changelog :cl: code: Rewrote a portion of storage UI code to allow it to be influenced by UI style. image: Prettified storage UI and made it affected by UI theme. /:cl: --------- Co-authored-by: san7890 <the@san7890.com>
## About The Pull Request Closes #84447 Closes #84445 Fixes incorrect assoc list deletion, storage deletion order and some math oopsies ## Changelog :cl: fix: Storage no longer deletes all of its viewers upon being deleted fix: Storage UI now renders properly /:cl:
## About The Pull Request https://github.com/user-attachments/assets/8949965f-a78a-4f3d-b528-afcdfe5c4e72 Drag'n'dropping items inside of an open storage that you can access will reorder them. I had to register dropping onto items themselves instead of cells as they ignore icon transparency when in storage for QOL reasons, so bear with that. ## Why It's Good For The Game Reordering your storage currently requires taking out all items in front of position that you want a certain item to be and putting them back in which could be rather annoying with large storages. ## Changelog :cl: qol: You can now reorder items inside storages by dragging them /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
awaiting attack chain refactor for full functionality, but ATM it works